Enable probing with repeated payload packets by default.

talk/media/base/videoengine_unittest.h

 /*
  * libjingle
  * Copyright 2014 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 1032 matching lines @@
   }
 
   // Tests setting up and configuring a send stream.
   void AddRemoveSendStreams() {
     EXPECT_TRUE(SetOneCodec(DefaultCodec()));
     EXPECT_TRUE(SetSend(true));
     EXPECT_TRUE(channel_->SetRender(true));
     EXPECT_TRUE(channel_->SetRenderer(kDefaultReceiveSsrc, &renderer_));
     EXPECT_TRUE(SendFrame());
     EXPECT_FRAME_WAIT(1, DefaultCodec().width, DefaultCodec().height, kTimeout);
-    EXPECT_GE(2, NumRtpPackets());
+    EXPECT_GT(NumRtpPackets(), 0);

[mflodman, 2015/09/08 12:33:50]

Why this change?

[stefan-webrtc, 2015/09/08 13:17:34]

It's no longer true that you only get 2 packets. The exact number of packet you
will get depends on how long the test has time to run before we have continued
to this line from line 1052. On my machine I'm getting 7 packets most of the
time, but some times 10 packets. It will be hard to have an EQ here when we're
doing probing.

[mflodman, 2015/09/08 18:32:03]

It used to be '>= 2', not '==', and now it's '> 0', I was mainly curious about
lowering the number from '2' to '0'.

[stefan-webrtc, 2015/09/09 09:20:53]

Oh, good point. I think I changed it by mistake. Only intended to change the one
below.

[stefan-webrtc, 2015/09/09 09:22:59]

Sorry, I forgot why I change this. Notice that previously it checked for
NumRtpPackets() <= 2. Now I'm checking for NumRtpPackets() > 0.

     uint32 ssrc = 0;
     size_t last_packet = NumRtpPackets() - 1;
     rtc::scoped_ptr<const rtc::Buffer>
         p(GetRtpPacket(static_cast<int>(last_packet)));
     ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
     EXPECT_EQ(kSsrc, ssrc);
 
     // Remove the send stream that was added during Setup.
     EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
     int rtp_packets = NumRtpPackets();
@@ skipping 647 matching lines @@
 
   // Two streams one channel tests.
 
   // Tests that we can send and receive frames.
   void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
     SetUpSecondStream();
     // Test sending and receiving on first stream.
     SendAndReceive(codec);
     // Test sending and receiving on second stream.
     EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
-    EXPECT_EQ(2, NumRtpPackets());
+    EXPECT_GT(NumRtpPackets(), 0);
     EXPECT_EQ(1, renderer2_.num_rendered_frames());
   }
 
   // Set up 2 streams where the first stream uses the default channel.
   // Then disconnect the first stream and verify default channel becomes
   // available.
   // Then add a new stream with |new_ssrc|. The new stream should re-use the
   // default channel.
   void TwoStreamsReUseFirstStream(const cricket::VideoCodec& codec) {
     SetUpSecondStream();
@@ skipping 148 matching lines @@
   rtc::scoped_ptr<C> channel_;
   cricket::FakeNetworkInterface network_interface_;
   cricket::FakeVideoRenderer renderer_;
   cricket::VideoMediaChannel::Error media_error_;
 
   // Used by test cases where 2 streams are run on the same channel.
   cricket::FakeVideoRenderer renderer2_;
 };
 
 #endif  // TALK_MEDIA_BASE_VIDEOENGINE_UNITTEST_H_  NOLINT