Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327033002: Remove unused TypingMonitor class. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, pthatcher1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused TypingMonitor class. BUG=webrtc:4690 Committed: https://crrev.com/8006f0759246407261b95c792f4febf3906415dc Cr-Commit-Position: refs/heads/master@{#9884}

Patch Set 1 #

Patch Set 2 : re-add files to not break Chromium #

Patch Set 3 : rebase #

Patch Set 4 : presubmit complaints #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -321 lines) Patch
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/session/media/channel.h View 5 chunks +1 line, -14 lines 0 comments Download
M talk/session/media/channel.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 6 chunks +0 lines, -40 lines 0 comments Download
D talk/session/media/typingmonitor.h View 1 2 3 1 chunk +1 line, -57 lines 0 comments Download
D talk/session/media/typingmonitor.cc View 1 2 3 1 chunk +2 lines, -95 lines 0 comments Download
D talk/session/media/typingmonitor_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
the sun
5 years, 3 months ago (2015-09-07 11:20:53 UTC) #2
tommi
lgtm
5 years, 3 months ago (2015-09-07 13:59:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327033002/40001
5 years, 3 months ago (2015-09-07 14:18:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/639)
5 years, 3 months ago (2015-09-07 14:28:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327033002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327033002/60001
5 years, 3 months ago (2015-09-07 14:44:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-07 16:44:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327033002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327033002/60001
5 years, 3 months ago (2015-09-07 17:58:13 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-07 19:58:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327033002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327033002/80001
5 years, 3 months ago (2015-09-08 07:47:37 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-08 09:57:05 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 09:57:14 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/8006f0759246407261b95c792f4febf3906415dc
Cr-Commit-Position: refs/heads/master@{#9884}

Powered by Google App Engine
This is Rietveld 408576698