Chromium Code Reviews

Issue 1324853003: Remove MediaChannel::GetOptions(). (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove [Voice|Video]MediaChannel::GetOptions(). BUG=webrtc:4690 Committed: https://crrev.com/66f43392a31ac566565e910246ef496fcbbafb04 Cr-Commit-Position: refs/heads/master@{#9904}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Stats (+26 lines, -69 lines)
M talk/app/webrtc/webrtcsession_unittest.cc View 4 chunks +5 lines, -10 lines 0 comments
M talk/media/base/fakemediaengine.h View 4 chunks +0 lines, -15 lines 0 comments
M talk/media/base/mediachannel.h View 2 chunks +0 lines, -2 lines 0 comments
M talk/media/sctp/sctpdataengine.h View 1 chunk +0 lines, -1 line 0 comments
M talk/media/webrtc/webrtcvideoengine2.h View 1 chunk +0 lines, -4 lines 0 comments
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +1 line, -4 lines 0 comments
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 5 chunks +11 lines, -15 lines 0 comments
M talk/session/media/channel_unittest.cc View 2 chunks +9 lines, -18 lines 0 comments

Messages

Total messages: 9 (3 generated)
the sun
5 years, 3 months ago (2015-09-07 12:43:38 UTC) #2
pthatcher1
5 years, 3 months ago (2015-09-09 07:17:46 UTC) #3
pthatcher1
lgtm
5 years, 3 months ago (2015-09-09 07:17:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1324853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1324853003/20001
5 years, 3 months ago (2015-09-09 07:47:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 08:36:30 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 08:36:41 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66f43392a31ac566565e910246ef496fcbbafb04
Cr-Commit-Position: refs/heads/master@{#9904}

Powered by Google App Engine