talk/media/webrtc/webrtcvoiceengine.h - Issue 1324853003: Remove MediaChannel::GetOptions().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/media/webrtc/webrtcvoiceengine.h

Issue 1324853003: Remove MediaChannel::GetOptions(). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/media/webrtc/webrtcvoiceengine.h

diff --git a/talk/media/webrtc/webrtcvoiceengine.h b/talk/media/webrtc/webrtcvoiceengine.h

index 313a371f7a977d1d90f6c0b6e7663eae230726ec..4b35ba7db256a444c199f5a6ac133b4d8ad0765a 100644

--- a/talk/media/webrtc/webrtcvoiceengine.h

+++ b/talk/media/webrtc/webrtcvoiceengine.h

@@ -285,14 +285,11 @@ class WebRtcVoiceMediaChannel : public VoiceMediaChannel,

int voe_channel() const { return voe_channel_; }

bool valid() const { return voe_channel_ != -1; }

+ const AudioOptions& options() const { return options_; }

bool SetSendParameters(const AudioSendParameters& params) override;

bool SetRecvParameters(const AudioRecvParameters& params) override;

bool SetOptions(const AudioOptions& options) override;

- bool GetOptions(AudioOptions* options) const override {

- *options = options_;

- return true;

- }

bool SetRecvCodecs(const std::vector<AudioCodec>& codecs) override;

bool SetSendCodecs(const std::vector<AudioCodec>& codecs) override;

bool SetRecvRtpHeaderExtensions(