CameraEnumerationAndroid: Make getSupportedFormats() an interface

CameraEnumerationAndroid: Make getSupportedFormats() an interface

Enumerating camera capabilities in the deprecated android.hardware.Camera interface is really slow because of the need to open and release the camera. By making getSupportedFormats() an interface, we allow apps the opportunity to inject their own implementation, such as storing the supported formats offline in the device's internal storage. It will also be possible to add an implementation of getSupportedFormats() using the new android.hardware.Camera2 interface in a follow-up CL.

R=tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/c252dabbd6bc98b0f725d221e58431128d4eed07

[magjed_webrtc, 2015-08-31 07:49:14]

magjed@webrtc.org changed reviewers:
+ tommi@webrtc.org

[magjed_webrtc, 2015-08-31 07:49:44]

Please take a look.

[tommi, 2015-08-31 07:55:06]

lgtm

[magjed_webrtc, 2015-08-31 10:18:16]

Please take another look. I reverted back to the old behaviour of enumerating
all cameras. The reason for this is that we otherwise can't enumerate the second
camera after we started capturing (because we can't have two open cameras).

[tommi, 2015-08-31 10:25:06]

lgtm with .release() moved.

https://codereview.webrtc.org/1321903002/diff/60001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/CameraEnumerator.java (right):

https://codereview.webrtc.org/1321903002/diff/60001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/CameraEnumerator.java:68:
camera.release();
move to finally (as discussed)?

[magjed_webrtc, 2015-08-31 11:18:35]

https://codereview.webrtc.org/1321903002/diff/60001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/CameraEnumerator.java (right):

https://codereview.webrtc.org/1321903002/diff/60001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/CameraEnumerator.java:68:
camera.release();
On 2015/08/31 10:25:06, tommi (webrtc) wrote:
> move to finally (as discussed)?

Done.

[magjed_webrtc, 2015-08-31 11:19:26]

Committed patchset #5 (id:80001) manually as
c252dabbd6bc98b0f725d221e58431128d4eed07 (presubmit successful).