talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java - Issue 1321903002: CameraEnumerationAndroid: Make getSupportedFormats() an interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

Issue 1321903002: CameraEnumerationAndroid: Make getSupportedFormats() an interface (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Release camera in finally clause Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

diff --git a/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java b/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

index 162fad1c3b37991bbb2d654dc3a98e22da679435..33b8c95986e673fcc82b5b59cdc42015e53ddb45 100644

--- a/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

+++ b/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

@@ -276,8 +276,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {

FakeCapturerObserver observer = new FakeCapturerObserver();

String deviceName = CameraEnumerationAndroid.getDeviceName(0);

- ArrayList<CaptureFormat> formats =

- CameraEnumerationAndroid.getSupportedFormats(0);

+ List<CaptureFormat> formats = CameraEnumerationAndroid.getSupportedFormats(0);

VideoCapturerAndroid capturer =

VideoCapturerAndroid.create(deviceName, null);

@@ -301,8 +300,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {