VideoRendererGui: Move to async rendering and remove no longer needed code

VideoRendererGui: Move to async rendering and remove no longer needed code

BUG=webrtc:4742, webrtc:4909
R=glaznev@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/7afc12fe91e97a3d68de3768a73f3604e5651504

[magjed_webrtc, 2015-08-29 17:15:48]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2015-08-31 08:58:54]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2015-08-31 08:59:03]

Please take a look.

[magjed_webrtc, 2015-09-02 21:24:34]

Ping

[AlexG, 2015-09-02 22:57:51]

lgtm

Sorry for the delay.
BTW, have you measured if moving to async rendering affect encoding fps
especially on not powerful KK or JB devices - I guess we will be not returning
frames back to camera pool as fast as it was (though reducing CPU usage). May be
it is worth to increase camera buffer pool to say 5 frames?

[AlexG, 2015-09-02 22:58:08]

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right):

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:247: if
(pendingFrame != null && startTimeNs == -1) {
nit: use isNewFrame here

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:251: if
(pendingFrame != null) {
ditto - use isNewFrame

[magjed_webrtc, 2015-09-03 10:39:56]

I tried to measure on an Android One compared to master, but both master and my
CL are spewing out "Frame returned when camera is running out of capture
buffers...". I will try to increase the pool to 5 frames and see if it helps,
but as a separate issue.

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
File talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java (right):

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:247: if
(pendingFrame != null && startTimeNs == -1) {
On 2015/09/02 22:58:08, AlexG wrote:
> nit: use isNewFrame here

Done.

https://codereview.webrtc.org/1321853003/diff/20001/talk/app/webrtc/java/andr...
talk/app/webrtc/java/android/org/webrtc/VideoRendererGui.java:251: if
(pendingFrame != null) {
On 2015/09/02 22:58:08, AlexG wrote:
> ditto - use isNewFrame

Done.

[magjed_webrtc, 2015-09-03 10:40:56]

Committed patchset #2 (id:40001) manually as
7afc12fe91e97a3d68de3768a73f3604e5651504 (presubmit successful).