Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1313753003: Remove VideoRendererInterface::CanApplyRotation() (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
AlexG, guoweis_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoRendererInterface::CanApplyRotation() All implementations handle rotation now, both internally in WebRTC and externally in Chromium. R=glaznev@webrtc.org, guoweis@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c2db810b8958588771282634d00b7e3954c9f5ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -129 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M talk/app/webrtc/mediastreaminterface.h View 1 chunk +0 lines, -9 lines 0 comments Download
M talk/app/webrtc/test/fakevideotrackrenderer.h View 3 chunks +5 lines, -21 lines 0 comments Download
M talk/app/webrtc/videotrack_unittest.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M talk/app/webrtc/videotrackrenderers.h View 2 chunks +2 lines, -10 lines 0 comments Download
M talk/app/webrtc/videotrackrenderers.cc View 2 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
magjed_webrtc
Please take a look. I have found these implementations of VideoRendererInterface in WebRTC: webrtc::RTCVideoRendererNativeAdapter webrtc_jni::VideoRendererWrapper ...
5 years, 3 months ago (2015-09-09 12:19:43 UTC) #2
guoweis_webrtc
On 2015/09/09 12:19:43, magjed_webrtc wrote: > Please take a look. I have found these implementations ...
5 years, 3 months ago (2015-09-09 16:18:16 UTC) #3
AlexG
lgtm
5 years, 3 months ago (2015-09-09 17:01:29 UTC) #4
magjed_webrtc
5 years, 3 months ago (2015-09-09 19:26:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c2db810b8958588771282634d00b7e3954c9f5ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698