Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: talk/app/webrtc/mediastreaminterface.h

Issue 1313753003: Remove VideoRendererInterface::CanApplyRotation() (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/java/jni/peerconnection_jni.cc ('k') | talk/app/webrtc/test/fakevideotrackrenderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/mediastreaminterface.h
diff --git a/talk/app/webrtc/mediastreaminterface.h b/talk/app/webrtc/mediastreaminterface.h
index ceca99b243420edd44b9721f324d9f807b491819..5911e85e8eff7d8c981dbfd6df2ed958abe16bb7 100644
--- a/talk/app/webrtc/mediastreaminterface.h
+++ b/talk/app/webrtc/mediastreaminterface.h
@@ -127,15 +127,6 @@ class VideoRendererInterface {
// rotation applied.
virtual void RenderFrame(const cricket::VideoFrame* frame) = 0;
- // TODO(guoweis): Remove this function. This is added as a temporary solution
- // until chrome renderers can apply rotation.
- // Whether the VideoRenderer has the ability to rotate the frame before being
- // displayed. The rotation of a frame is carried by
- // VideoFrame.GetVideoRotation() and is the clockwise angle the frames must be
- // rotated in order to display the frames correctly. If returning false, the
- // frame's rotation must be applied before being delivered by RenderFrame.
- virtual bool CanApplyRotation() { return false; }
-
protected:
// The destructor is protected to prevent deletion via the interface.
// This is so that we allow reference counted classes, where the destructor
« no previous file with comments | « talk/app/webrtc/java/jni/peerconnection_jni.cc ('k') | talk/app/webrtc/test/fakevideotrackrenderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698