Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1311843006: Revert of purge nss files and dependencies (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of purge nss files and dependencies (patchset #1 id:1 of https://codereview.webrtc.org/1313233005/ ) Reason for revert: It looks like this broke the FYI bots. I tried updating libjingle_nacl.gyp, but the IOS build still failed because in Chrome it's configured to use NSS. See https://codereview.chromium.org/1316863012/. Original issue's description: > purge nss files and dependencies > > BUG=webrtc:4497 > > Committed: https://crrev.com/5647a2cf3db888195c928a1259d98f72f6ecbc15 > Cr-Commit-Position: refs/heads/master@{#9862} TBR=tommi@webrtc.org,kjellander@webrtc.org,torbjorng@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4497 Committed: https://crrev.com/9eb1365939683cc5462a5359344148efb7d84f97 Cr-Commit-Position: refs/heads/master@{#9867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2206 lines, -10 lines) Patch
M talk/media/sctp/sctpdataengine_unittest.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 3 chunks +42 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +45 lines, -0 lines 0 comments Download
M webrtc/base/helpers.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/base/nssidentity.h View 1 chunk +143 lines, -0 lines 0 comments Download
A webrtc/base/nssidentity.cc View 1 chunk +581 lines, -0 lines 0 comments Download
A webrtc/base/nssstreamadapter.h View 1 chunk +125 lines, -0 lines 0 comments Download
A webrtc/base/nssstreamadapter.cc View 1 chunk +1127 lines, -0 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/ssladapter.cc View 3 chunks +21 lines, -3 lines 0 comments Download
M webrtc/base/sslconfig.h View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/base/sslidentity.cc View 2 chunks +25 lines, -1 line 0 comments Download
M webrtc/base/sslidentity_unittest.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 3 chunks +23 lines, -3 lines 0 comments Download
M webrtc/base/sslstreamadapter_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M webrtc/base/sslstreamadapterhelper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/lsan_suppressions_webrtc.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Taylor Brandstetter
Created Revert of purge nss files and dependencies
3 years, 10 months ago (2015-09-04 23:01:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843006/1
3 years, 10 months ago (2015-09-04 23:01:46 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
3 years, 10 months ago (2015-09-04 23:01:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843006/1
3 years, 10 months ago (2015-09-04 23:06:27 UTC) #6
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
3 years, 10 months ago (2015-09-04 23:06:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843006/1
3 years, 10 months ago (2015-09-05 11:36:47 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
3 years, 10 months ago (2015-09-05 11:36:49 UTC) #12
tommi
lgtm
3 years, 10 months ago (2015-09-05 11:39:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843006/1
3 years, 10 months ago (2015-09-05 11:39:08 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 10 months ago (2015-09-05 11:39:20 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2015-09-05 11:39:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eb1365939683cc5462a5359344148efb7d84f97
Cr-Commit-Position: refs/heads/master@{#9867}

Powered by Google App Engine
This is Rietveld 408576698