Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1311743003: Get rid of unused types and constants in acm_common_defs.h (Closed)

Created:
5 years, 4 months ago by kwiberg-webrtc
Modified:
5 years, 4 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@manual-dtor
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_common_defs.h View 3 chunks +1 line, -46 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
kwiberg-webrtc
I'll be removing one more thing in a later CL, but here's all the things ...
5 years, 4 months ago (2015-08-25 09:42:55 UTC) #3
kwiberg-webrtc
On 2015/08/25 09:42:55, kwiberg-webrtc wrote: > I'll be removing one more thing in a later ...
5 years, 4 months ago (2015-08-25 09:43:12 UTC) #4
hlundin-webrtc
Good riddance! LGTM.
5 years, 4 months ago (2015-08-25 12:38:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311743003/1
5 years, 4 months ago (2015-08-25 13:06:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) mac_baremetal on ...
5 years, 4 months ago (2015-08-25 15:07:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311743003/1
5 years, 4 months ago (2015-08-25 15:09:40 UTC) #11
kwiberg-webrtc
5 years, 4 months ago (2015-08-25 15:32:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4772ee436628ca8659bc18f6f900d2f5f1e3d31 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698