Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1310213003: Get rid of the manual destructor in AudioCodingModuleImpl (Closed)

Created:
5 years, 4 months ago by kwiberg-webrtc
Modified:
5 years, 4 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove-unused
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Get rid of the manual destructor in AudioCodingModuleImpl By converting three raw pointers to scoped_ptrs, we can eliminate the need for a manually-defined destructor, and generally sleep better at night. R=henrik.lundin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/b6cac8f5ef118a5c45165047bea067188a4524b4

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : Remove existing TODO and add a new one #

Patch Set 4 : error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -52 lines) Patch
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 2 3 27 chunks +36 lines, -48 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
kwiberg-webrtc
5 years, 4 months ago (2015-08-24 13:24:36 UTC) #2
hlundin-webrtc
I like sleeping at night, but I have a question. https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc#newcode708 ...
5 years, 4 months ago (2015-08-24 13:29:21 UTC) #3
kwiberg-webrtc
https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc#newcode708 webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc:708: if (!aux_rtp_header_) { On 2015/08/24 13:29:21, hlundin-webrtc wrote: > ...
5 years, 4 months ago (2015-08-24 13:51:46 UTC) #4
hlundin-webrtc
lgtm https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc#newcode708 webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc:708: if (!aux_rtp_header_) { On 2015/08/24 13:51:46, kwiberg-webrtc wrote: ...
5 years, 4 months ago (2015-08-24 14:01:12 UTC) #5
kwiberg-webrtc
https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc File webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc (right): https://codereview.webrtc.org/1310213003/diff/1/webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc#newcode708 webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc:708: if (!aux_rtp_header_) { On 2015/08/24 14:01:12, hlundin-webrtc wrote: > ...
5 years, 4 months ago (2015-08-25 07:47:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310213003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310213003/60001
5 years, 4 months ago (2015-08-25 07:49:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn/builds/5186)
5 years, 4 months ago (2015-08-25 07:50:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1310213003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1310213003/80001
5 years, 4 months ago (2015-08-25 08:35:18 UTC) #15
kwiberg-webrtc
5 years, 4 months ago (2015-08-25 09:48:42 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:80001) manually as
b6cac8f5ef118a5c45165047bea067188a4524b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698