Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: webrtc/modules/audio_coding/main/interface/audio_coding_module.h

Issue 1310213003: Get rid of the manual destructor in AudioCodingModuleImpl (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove-unused
Patch Set: error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 /////////////////////////////////////////////////////////////////////////// 95 ///////////////////////////////////////////////////////////////////////////
96 // Creation and destruction of a ACM. 96 // Creation and destruction of a ACM.
97 // 97 //
98 // The second method is used for testing where a simulated clock can be 98 // The second method is used for testing where a simulated clock can be
99 // injected into ACM. ACM will take the ownership of the object clock and 99 // injected into ACM. ACM will take the ownership of the object clock and
100 // delete it when destroyed. 100 // delete it when destroyed.
101 // 101 //
102 static AudioCodingModule* Create(int id); 102 static AudioCodingModule* Create(int id);
103 static AudioCodingModule* Create(int id, Clock* clock); 103 static AudioCodingModule* Create(int id, Clock* clock);
104 static AudioCodingModule* Create(const Config& config); 104 static AudioCodingModule* Create(const Config& config);
105 virtual ~AudioCodingModule() {}; 105 virtual ~AudioCodingModule() = default;
106 106
107 /////////////////////////////////////////////////////////////////////////// 107 ///////////////////////////////////////////////////////////////////////////
108 // Utility functions 108 // Utility functions
109 // 109 //
110 110
111 /////////////////////////////////////////////////////////////////////////// 111 ///////////////////////////////////////////////////////////////////////////
112 // uint8_t NumberOfCodecs() 112 // uint8_t NumberOfCodecs()
113 // Returns number of supported codecs. 113 // Returns number of supported codecs.
114 // 114 //
115 // Return value: 115 // Return value:
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
1042 virtual std::vector<uint16_t> GetNackList(int round_trip_time_ms) const = 0; 1042 virtual std::vector<uint16_t> GetNackList(int round_trip_time_ms) const = 0;
1043 1043
1044 // Returns the timing statistics for calls to Get10MsAudio. 1044 // Returns the timing statistics for calls to Get10MsAudio.
1045 virtual void GetDecodingCallStatistics( 1045 virtual void GetDecodingCallStatistics(
1046 AudioDecodingCallStats* call_stats) const = 0; 1046 AudioDecodingCallStats* call_stats) const = 0;
1047 }; 1047 };
1048 1048
1049 } // namespace webrtc 1049 } // namespace webrtc
1050 1050
1051 #endif // WEBRTC_MODULES_AUDIO_CODING_MAIN_INTERFACE_AUDIO_CODING_MODULE_H_ 1051 #endif // WEBRTC_MODULES_AUDIO_CODING_MAIN_INTERFACE_AUDIO_CODING_MODULE_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698