Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1311533009: - Rename VoiceChannel::MuteStream() -> SetAudioSend() (incl. media channel) (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@lj_remove_typingmonitor_files
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Rename VoiceChannel::MuteStream() -> SetAudioSend() (incl. media channel) - Rename VideoChannel::MuteStream() -> SetVideoSend() (incl. media channel) - Collapse NnChannel::SetChannelOptions() into the above. - Collapse VoiceChannel::SetLocalRenderer into SetAudioSend(). BUG=webrtc:4690 Committed: https://crrev.com/1dd98f321920c1442dd5b3f791ea0fca133c2756 Cr-Commit-Position: refs/heads/master@{#9915}

Patch Set 1 #

Total comments: 8

Patch Set 2 : comments #

Patch Set 3 : more consistent #

Patch Set 4 : updated tests #

Patch Set 5 : rebase+one more test #

Total comments: 10

Patch Set 6 : comments #

Patch Set 7 : TODOs #

Patch Set 8 : rebase #

Patch Set 9 : typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -212 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 2 3 4 5 6 chunks +51 lines, -29 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 1 2 3 4 1 chunk +9 lines, -16 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 2 3 4 5 6 7 8 1 chunk +14 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 4 3 chunks +4 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 4 5 6 7 8 1 chunk +17 lines, -0 lines 0 comments Download
M talk/session/media/channel.h View 1 8 chunks +9 lines, -14 lines 0 comments Download
M talk/session/media/channel.cc View 7 chunks +11 lines, -39 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 1 2 3 4 8 chunks +40 lines, -88 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (3 generated)
the sun
Let me know whether you approve on the approach before I update the tests.
5 years, 3 months ago (2015-09-08 11:32:44 UTC) #2
pthatcher1
The general approach looks good to me. https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h File talk/media/base/fakemediaengine.h (right): https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h#newcode312 talk/media/base/fakemediaengine.h:312: } I ...
5 years, 3 months ago (2015-09-09 07:16:12 UTC) #3
the sun
https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h File talk/media/base/fakemediaengine.h (right): https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h#newcode312 talk/media/base/fakemediaengine.h:312: } On 2015/09/09 07:16:12, pthatcher1 wrote: > I think ...
5 years, 3 months ago (2015-09-09 09:50:50 UTC) #4
the sun
On 2015/09/09 09:50:50, the sun wrote: > https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h > File talk/media/base/fakemediaengine.h (right): > > https://codereview.webrtc.org/1311533009/diff/1/talk/media/base/fakemediaengine.h#newcode312 ...
5 years, 3 months ago (2015-09-09 11:53:14 UTC) #5
pthatcher1
Everything looks good. I'm just not sure if we need to handle atomic/rollback semantics or ...
5 years, 3 months ago (2015-09-09 14:25:14 UTC) #6
the sun
https://codereview.webrtc.org/1311533009/diff/80001/talk/media/base/fakemediaengine.h File talk/media/base/fakemediaengine.h (right): https://codereview.webrtc.org/1311533009/diff/80001/talk/media/base/fakemediaengine.h#newcode299 talk/media/base/fakemediaengine.h:299: } On 2015/09/09 14:25:14, pthatcher1 wrote: > nit: Could ...
5 years, 3 months ago (2015-09-09 14:52:11 UTC) #7
pthatcher1
lgtm
5 years, 3 months ago (2015-09-09 23:43:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311533009/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311533009/160001
5 years, 3 months ago (2015-09-10 08:04:53 UTC) #11
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 3 months ago (2015-09-10 08:57:19 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 08:57:29 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/1dd98f321920c1442dd5b3f791ea0fca133c2756
Cr-Commit-Position: refs/heads/master@{#9915}

Powered by Google App Engine
This is Rietveld 408576698