Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1308663005: Remove obsolete typingmonitor.cc/.h files. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@lj_remove_typingmonitor
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove obsolete typingmonitor.cc/.h files. To be committed once https://codereview.webrtc.org/1327033002/ has propagated to Chromium, and Chromium's libjingle.gyp has been updated. BUG=webrtc:4690 Committed: https://crrev.com/fab882b193fa44f4c83c76fcbf67683b179978cf Cr-Commit-Position: refs/heads/master@{#9919}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -58 lines) Patch
D talk/session/media/typingmonitor.h View 1 1 chunk +0 lines, -28 lines 0 comments Download
D talk/session/media/typingmonitor.cc View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
the sun
5 years, 3 months ago (2015-09-07 11:26:55 UTC) #2
tommi
lgtm
5 years, 3 months ago (2015-09-07 13:59:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308663005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308663005/20001
5 years, 3 months ago (2015-09-10 12:19:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_arm64_rel on ...
5 years, 3 months ago (2015-09-10 14:19:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308663005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308663005/20001
5 years, 3 months ago (2015-09-10 14:21:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-10 15:38:16 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 15:38:27 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fab882b193fa44f4c83c76fcbf67683b179978cf
Cr-Commit-Position: refs/heads/master@{#9919}

Powered by Google App Engine
This is Rietveld 408576698