Use RtcpPacket to send APP in RtcpSender

webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

Index: webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
index 843ec1605d095828ae5efdd87e06d1c66ebcc933..5484ec3ff436273b451f608c8a496e3877871bda 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
@@ -389,6 +389,20 @@ TEST_F(RtcpSenderTest, SendApp) {
       parser()->app_item()->DataLength()));
 }
 
+TEST_F(RtcpSenderTest, SendEmptyApp) {
+  const uint8_t kSubType = 30;
+  const uint32_t name = 0x6E616D65;

[åsapersson, 2015/08/31 14:32:52]

kName

[sprang_webrtc, 2015/08/31 15:29:28]

Done.

+
+  EXPECT_EQ(
+      0, rtcp_sender_->SetApplicationSpecificData(kSubType, name, nullptr, 0));
+
+  rtcp_sender_->SetRTCPStatus(kRtcpNonCompound);
+  EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpApp));
+  EXPECT_EQ(1, parser()->app()->num_packets());
+  EXPECT_EQ(kSubType, parser()->app()->SubType());
+  EXPECT_EQ(name, parser()->app()->Name());

[åsapersson, 2015/08/31 14:32:52]

maybe check that there is no app_item

[sprang_webrtc, 2015/08/31 15:29:28]

Done.

+}
+
 TEST_F(RtcpSenderTest, SetInvalidApplicationSpecificData) {
   const uint8_t kData[] = {'t', 'e', 's', 't', 'd', 'a', 't'};
   const uint16_t kInvalidDataLength = sizeof(kData) / sizeof(kData[0]);