Use RtcpPacket to send APP in RtcpSender

webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 371 matching lines @@
   EXPECT_EQ(1, parser()->app()->num_packets());
   EXPECT_EQ(kSubType, parser()->app()->SubType());
   EXPECT_EQ(name, parser()->app()->Name());
   EXPECT_EQ(1, parser()->app_item()->num_packets());
   EXPECT_EQ(kDataLength, parser()->app_item()->DataLength());
   EXPECT_EQ(0, strncmp(reinterpret_cast<const char*>(kData),
       reinterpret_cast<const char*>(parser()->app_item()->Data()),
       parser()->app_item()->DataLength()));
 }
 
+TEST_F(RtcpSenderTest, SendEmptyApp) {
+  const uint8_t kSubType = 30;
+  const uint32_t name = 0x6E616D65;

[åsapersson, 2015/08/31 14:32:52]

kName

[sprang_webrtc, 2015/08/31 15:29:28]

Done.

+
+  EXPECT_EQ(
+      0, rtcp_sender_->SetApplicationSpecificData(kSubType, name, nullptr, 0));
+
+  rtcp_sender_->SetRTCPStatus(kRtcpNonCompound);
+  EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpApp));
+  EXPECT_EQ(1, parser()->app()->num_packets());
+  EXPECT_EQ(kSubType, parser()->app()->SubType());
+  EXPECT_EQ(name, parser()->app()->Name());

[åsapersson, 2015/08/31 14:32:52]

maybe check that there is no app_item

[sprang_webrtc, 2015/08/31 15:29:28]

Done.

+}
+
 TEST_F(RtcpSenderTest, SetInvalidApplicationSpecificData) {
   const uint8_t kData[] = {'t', 'e', 's', 't', 'd', 'a', 't'};
   const uint16_t kInvalidDataLength = sizeof(kData) / sizeof(kData[0]);
   EXPECT_EQ(-1, rtcp_sender_->SetApplicationSpecificData(
       0, 0, kData, kInvalidDataLength));  // Should by multiple of 4.
 }
 
 TEST_F(RtcpSenderTest, SendFirNonRepeat) {
   rtcp_sender_->SetRTCPStatus(kRtcpNonCompound);
   EXPECT_EQ(0, rtcp_sender_->SendRTCP(feedback_state(), kRtcpFir));
@@ skipping 339 matching lines @@
   rtcp_sender_->SetREMBData(kBitrate, ssrcs);
   std::set<RTCPPacketType> packet_types;
   packet_types.insert(kRtcpRemb);
   packet_types.insert(kRtcpPli);
   EXPECT_EQ(0, rtcp_sender_->SendCompoundRTCP(feedback_state(), packet_types));
   EXPECT_EQ(1, parser()->remb_item()->num_packets());
   EXPECT_EQ(1, parser()->pli()->num_packets());
 }
 
 }  // namespace webrtc