Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1309723002: Reland of Use RtcpPacket to send REMB in RtcpSender (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1 of https://codereview.webrtc.org/1300863002/ ) Reason for revert: This wasn't the cause of the breakage. Re-reverting. https://code.google.com/p/webrtc/issues/detail?id=4923 Original issue's description: > Revert of Use RtcpPacket to send REMB in RtcpSender (patchset #1 id:1 of https://codereview.webrtc.org/1290573004/ ) > > Reason for revert: > A few bots started failing rtc_unittests after this was commited. Ex https://build.chromium.org/p/client.webrtc/builders/Linux64%20Debug/builds/5048 > > Original issue's description: > > Use RtcpPacket to send REMB in RtcpSender > > > > BUG=webrtc:2450 > > R=asapersson@webrtc.org > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/35ab4baa20a730de71b390008900a16563cbbe8e > > TBR=asapersson@webrtc.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:2450 > > Committed: https://crrev.com/141c5951f4beda868797c2746002a4b1b267ab2a > Cr-Commit-Position: refs/heads/master@{#9723} TBR=asapersson@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:2450 Committed: https://crrev.com/dd4edc5813a0331049f53a93ac2404a8899e6ae8 Cr-Commit-Position: refs/heads/master@{#9754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -41 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +9 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sprang_webrtc
Created Reland of Use RtcpPacket to send REMB in RtcpSender
5 years, 4 months ago (2015-08-21 11:21:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309723002/1
5 years, 4 months ago (2015-08-21 11:21:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 11:21:55 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 11:22:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd4edc5813a0331049f53a93ac2404a8899e6ae8
Cr-Commit-Position: refs/heads/master@{#9754}

Powered by Google App Engine
This is Rietveld 408576698