Revert "Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)…

Revert "Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots.""

This reverts commit 081f34b564e1a26ffbbe9515eba1fef7c736fdde.

Original code review see
https://codereview.webrtc.org/1291363005


The revert is due to a suspicion of "Reland "Remove GICE..." being the cause of failure on Linux memcheck, see
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/4137

TBR=pthatcher@webrtc.org, 

BUG=

Committed: https://chromium.googlesource.com/external/webrtc/+/5bdafd44c86ee46bd7e040f19828324583418b33

[minyue-webrtc, 2015-08-21 09:49:42]

minyue@webrtc.org changed reviewers:
+ pthatcher@chromium.org

[minyue-webrtc, 2015-08-21 09:55:00]

minyue@webrtc.org changed reviewers:
+ pthatcher@webrtc.org
- pthatcher@chromium.org

[minyue-webrtc, 2015-08-21 12:46:24]

Patchset #2 (id:20001) has been deleted

[minyue-webrtc, 2015-08-21 13:19:57]

Hi Peter,

As sheriff, I revert your CL for you to make further investigation.

The revert was not simple and please double check the marked place and patch set
2.

Thanks!

https://codereview.webrtc.org/1308753003/diff/1/webrtc/p2p/base/p2ptransportc...
File webrtc/p2p/base/p2ptransportchannel.cc (right):

https://codereview.webrtc.org/1308753003/diff/1/webrtc/p2p/base/p2ptransportc...
webrtc/p2p/base/p2ptransportchannel.cc:1028: // We don't want to pick the best
connections if channel is using RFC5245.
Merge against https://codereview.webrtc.org/1299333003 with best effort. Please
double check.

[minyue-webrtc, 2015-08-21 13:20:07]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2015-08-21 13:20:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308753003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308753003/40001

[commit-bot: I haz the power, 2015-08-21 13:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 13:22:21]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/451)

[minyue-webrtc, 2015-08-21 13:53:06]

Committed patchset #2 (id:40001) manually as
5bdafd44c86ee46bd7e040f19828324583418b33 (presubmit successful).

[Andrew MacDonald, 2015-08-21 17:26:51]

Arg, sorry Minyue, I should have emailed you about this. Peter and I tried to
repro the memcheck failure locally yesterday and were unable to. I suspected
this CL wasn't the cause, but your revert should shortly settle the matter.