Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1299333003: Relanding Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefi… (Closed)

Created:
5 years, 4 months ago by guoweis_webrtc
Modified:
5 years, 4 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relanding "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied." Migrated from https://codereview.webrtc.org/1275703006/ which causes test failures for android. On android, loopback interface was used as local interface to generate candidates. Add a test case to make sure this won't be broken in the future. Also observed some failures under content_browsertests in chromium.fyi bot but can't repro locally. Might just be temporary test issue. BUG=webrtc:4517 TBR=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/fe3bc9d5aeffed8bbfb34c330d8b991abd1a1aba

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -46 lines) Patch
M talk/app/webrtc/peerconnectioninterface.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/base/ipaddress.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/ipaddress.cc View 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/stunport.h View 1 2 6 chunks +16 lines, -7 lines 0 comments Download
M webrtc/p2p/base/stunport.cc View 1 2 3 4 chunks +19 lines, -5 lines 0 comments Download
M webrtc/p2p/base/stunport_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 2 chunks +19 lines, -12 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 8 chunks +58 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299333003/1
5 years, 4 months ago (2015-08-19 21:14:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299333003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299333003/40001
5 years, 4 months ago (2015-08-20 04:55:34 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux/builds/9112)
5 years, 4 months ago (2015-08-20 05:05:40 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299333003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299333003/60001
5 years, 4 months ago (2015-08-20 05:33:42 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-20 07:33:50 UTC) #11
guoweis_webrtc
5 years, 4 months ago (2015-08-20 15:48:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
fe3bc9d5aeffed8bbfb34c330d8b991abd1a1aba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698