Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308283003: Remove no-op and unused methods from AudioCodingModule (Closed)

Created:
5 years, 4 months ago by kwiberg-webrtc
Modified:
5 years, 4 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove no-op and unused methods from AudioCodingModule This CL removes the following no-op and/or unused methods from AudioCodingModule and AudioCodingModuleImpl: ConfigISACBandwidthEstimator DecoderEstimatedBandwidth IsInternalDTXReplacedWithWebRtc REDPayloadISAC ReplaceInternalDTXWithWebRtc ResetDecoder ResetEncoder SendBitrate SetReceivedEstimatedBandwidth R=henrik.lundin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/dd00f113a95e589c0e3386d1a3ad87348e28ab2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -334 lines) Patch
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 6 chunks +1 line, -37 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 8 chunks +0 lines, -138 lines 0 comments Download
M webrtc/modules/audio_coding/main/interface/audio_coding_module.h View 6 chunks +0 lines, -125 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/APITest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TestVADDTX.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/main/test/TestVADDTX.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/TwoWayCommunication.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/main/test/iSACTest.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Issue 1310213003 Patch 1

Messages

Total messages: 7 (3 generated)
kwiberg-webrtc
🎵 Please take a look 🎶 (sung to the tune of https://www.youtube.com/watch?v=LlVI7ZNiFlI)
5 years, 4 months ago (2015-08-24 13:07:58 UTC) #2
hlundin-webrtc
On 2015/08/24 13:07:58, kwiberg-webrtc wrote: > 🎵 Please take a look 🎶 > > (sung ...
5 years, 4 months ago (2015-08-24 13:18:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308283003/1
5 years, 4 months ago (2015-08-25 06:29:33 UTC) #5
kwiberg-webrtc
5 years, 4 months ago (2015-08-25 07:37:23 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dd00f113a95e589c0e3386d1a3ad87348e28ab2d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698