Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: webrtc/common_video/i420_buffer_pool.cc

Issue 1304143003: VideoFrameBuffer: Make non-const data access explicit (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/webrtc/webrtcvideoframe.cc ('k') | webrtc/common_video/i420_buffer_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/i420_buffer_pool.cc
diff --git a/webrtc/common_video/i420_buffer_pool.cc b/webrtc/common_video/i420_buffer_pool.cc
index 4b8695824c794ef50f402b4cc2a22e06cc73ded3..cb1f4d4022d49c7fd037fec9861562beb47b7acb 100644
--- a/webrtc/common_video/i420_buffer_pool.cc
+++ b/webrtc/common_video/i420_buffer_pool.cc
@@ -27,13 +27,13 @@ class PooledI420Buffer : public webrtc::VideoFrameBuffer {
int width() const override { return buffer_->width(); }
int height() const override { return buffer_->height(); }
const uint8_t* data(webrtc::PlaneType type) const override {
- const webrtc::I420Buffer* cbuffer = buffer_.get();
- return cbuffer->data(type);
+ return buffer_->data(type);
}
- uint8_t* data(webrtc::PlaneType type) {
+ uint8_t* MutableData(webrtc::PlaneType type) override {
+ // Make the HasOneRef() check here instead of in |buffer_|, because the pool
+ // also has a reference to |buffer_|.
DCHECK(HasOneRef());
- const webrtc::I420Buffer* cbuffer = buffer_.get();
- return const_cast<uint8_t*>(cbuffer->data(type));
+ return const_cast<uint8_t*>(buffer_->data(type));
}
int stride(webrtc::PlaneType type) const override {
return buffer_->stride(type);
« no previous file with comments | « talk/media/webrtc/webrtcvideoframe.cc ('k') | webrtc/common_video/i420_buffer_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698