Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: talk/media/webrtc/webrtcvideoframe.cc

Issue 1304143003: VideoFrameBuffer: Make non-const data access explicit (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/common_video/i420_buffer_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/webrtc/webrtcvideoframe.cc
diff --git a/talk/media/webrtc/webrtcvideoframe.cc b/talk/media/webrtc/webrtcvideoframe.cc
index 055e24d3cd2d75bf5cd9bb6f1380d58cd49a4683..e72ab144f0e5480d9c9619542452d45863ed9bf3 100644
--- a/talk/media/webrtc/webrtcvideoframe.cc
+++ b/talk/media/webrtc/webrtcvideoframe.cc
@@ -117,33 +117,30 @@ size_t WebRtcVideoFrame::GetHeight() const {
}
const uint8* WebRtcVideoFrame::GetYPlane() const {
- // Const cast to call the correct const-version of data.
- const webrtc::VideoFrameBuffer* const_ptr = video_frame_buffer_.get();
- return const_ptr ? const_ptr->data(kYPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->data(kYPlane) : nullptr;
}
const uint8* WebRtcVideoFrame::GetUPlane() const {
- // Const cast to call the correct const-version of data.
- const webrtc::VideoFrameBuffer* const_ptr = video_frame_buffer_.get();
- return const_ptr ? const_ptr->data(kUPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->data(kUPlane) : nullptr;
}
const uint8* WebRtcVideoFrame::GetVPlane() const {
- // Const cast to call the correct const-version of data.
- const webrtc::VideoFrameBuffer* const_ptr = video_frame_buffer_.get();
- return const_ptr ? const_ptr->data(kVPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->data(kVPlane) : nullptr;
}
uint8* WebRtcVideoFrame::GetYPlane() {
- return video_frame_buffer_ ? video_frame_buffer_->data(kYPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->MutableData(kYPlane)
+ : nullptr;
}
uint8* WebRtcVideoFrame::GetUPlane() {
- return video_frame_buffer_ ? video_frame_buffer_->data(kUPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->MutableData(kUPlane)
+ : nullptr;
}
uint8* WebRtcVideoFrame::GetVPlane() {
- return video_frame_buffer_ ? video_frame_buffer_->data(kVPlane) : nullptr;
+ return video_frame_buffer_ ? video_frame_buffer_->MutableData(kVPlane)
+ : nullptr;
}
int32 WebRtcVideoFrame::GetYPitch() const {
@@ -192,9 +189,10 @@ bool WebRtcVideoFrame::MakeExclusive() {
video_frame_buffer_->stride(kUPlane),
video_frame_buffer_->stride(kVPlane));
- if (!CopyToPlanes(new_buffer->data(kYPlane), new_buffer->data(kUPlane),
- new_buffer->data(kVPlane), new_buffer->stride(kYPlane),
- new_buffer->stride(kUPlane), new_buffer->stride(kVPlane))) {
+ if (!CopyToPlanes(
+ new_buffer->MutableData(kYPlane), new_buffer->MutableData(kUPlane),
+ new_buffer->MutableData(kVPlane), new_buffer->stride(kYPlane),
+ new_buffer->stride(kUPlane), new_buffer->stride(kVPlane))) {
return false;
}
« no previous file with comments | « no previous file | webrtc/common_video/i420_buffer_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698