VideoFrameBuffer: Make non-const data access explicit

VideoFrameBuffer: Make non-const data access explicit

VideoFrameBuffer currently has two overloaded data() functions for pixel access, one for const and one for non-const. Unfortunately, it will default to the non-const version, even when 'const scoped_refptr<VideoFrameBuffer>&' is used. This is a problem, because many subclasses use RTC_NOTREACHED() in the non-const version.

This CL makes the non-const version of data() explicit with a different, longer function name MutableData().

R=tommi@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/3318f984cd7f51d24da4726665c05f5f06f82e6d

[magjed_webrtc, 2015-08-21 11:33:32]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-21 11:33:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304143003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304143003/1

[magjed_webrtc, 2015-08-21 11:36:49]

magjed@webrtc.org changed reviewers:
+ tommi@webrtc.org

[commit-bot: I haz the power, 2015-08-21 11:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 11:44:32]

Dry run: Try jobs failed on following builders:
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/8890)

[magjed_webrtc, 2015-08-21 14:57:32]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[magjed_webrtc, 2015-08-21 14:57:43]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2015-08-21 14:57:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1304143003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1304143003/20001

[commit-bot: I haz the power, 2015-08-21 17:40:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 17:40:43]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2015-08-24 08:01:36]

Please take a look.

[tommi, 2015-08-24 09:59:09]

lgtm

[magjed_webrtc, 2015-08-26 14:06:36]

Committed patchset #2 (id:40001) manually as
3318f984cd7f51d24da4726665c05f5f06f82e6d (presubmit successful).

[noahric, 2015-08-26 15:03:13]

On 2015/08/26 14:06:36, magjed_webrtc wrote:
> Committed patchset #2 (id:40001) manually as
> 3318f984cd7f51d24da4726665c05f5f06f82e6d (presubmit successful).

FYI, I'm seeing buildbot failures from this CL:
In file included from
../../content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:5:
../../content/renderer/media/webrtc/webrtc_video_frame_adapter.h:27:41: error:
only virtual member functions can be marked 'override'
  uint8_t* data(webrtc::PlaneType type) override;

http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20GN%20%28dbg%...

Looks like webrtc_video_frame_adapter.h also needs to be updated?

[magjed_webrtc, 2015-08-26 15:11:30]

On 2015/08/26 15:03:13, noahric wrote:
> On 2015/08/26 14:06:36, magjed_webrtc wrote:
> > Committed patchset #2 (id:40001) manually as
> > 3318f984cd7f51d24da4726665c05f5f06f82e6d (presubmit successful).
> 
> FYI, I'm seeing buildbot failures from this CL:
> In file included from
> ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.cc:5:
> ../../content/renderer/media/webrtc/webrtc_video_frame_adapter.h:27:41: error:
> only virtual member functions can be marked 'override'
>   uint8_t* data(webrtc::PlaneType type) override;
> 
>
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20GN%20%28dbg%...
> 
> Looks like webrtc_video_frame_adapter.h also needs to be updated?

Yes, I have spoken with grunell, the webrtc-in-chrome sheriff. I'm doing a
custom roll right now:
https://codereview.chromium.org/1310213008/
The Chromium waterfall is not in a good right now though.