Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1303393002: Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becau… (Closed)

Created:
5 years, 4 months ago by pthatcher1
Modified:
5 years, 4 months ago
Reviewers:
guoweis_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becauese remoting code is using dead constants and breaks the FYI bots. This reverts commit 5bdafd44c86ee46bd7e040f19828324583418b33. Original CL: https://codereview.webrtc.org/1263663002/ R=guoweis@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/2159b89fa2cb55beeef38f72bd45e217f3d33d4e

Patch Set 1 #

Patch Set 2 : Add memcheck suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -2341 lines) Patch
M talk/app/webrtc/jsepsessiondescription_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 4 chunks +0 lines, -53 lines 0 comments Download
M talk/app/webrtc/webrtcsdp.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 8 chunks +7 lines, -17 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 10 chunks +6 lines, -73 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +0 lines, -19 lines 0 comments Download
M talk/session/media/mediasession.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
M webrtc/p2p/base/candidate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/constants.h View 2 chunks +0 lines, -14 lines 0 comments Download
M webrtc/p2p/base/constants.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 7 chunks +2 lines, -32 lines 0 comments Download
M webrtc/p2p/base/fakesession.h View 5 chunks +1 line, -9 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 15 chunks +73 lines, -162 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 32 chunks +148 lines, -268 lines 0 comments Download
M webrtc/p2p/base/port.h View 4 chunks +1 line, -22 lines 0 comments Download
M webrtc/p2p/base/port.cc View 24 chunks +69 lines, -207 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 31 chunks +68 lines, -372 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/rawtransport.h View 1 chunk +2 lines, -46 lines 0 comments Download
M webrtc/p2p/base/rawtransport.cc View 1 chunk +2 lines, -43 lines 0 comments Download
M webrtc/p2p/base/rawtransportchannel.h View 1 chunk +2 lines, -200 lines 0 comments Download
M webrtc/p2p/base/rawtransportchannel.cc View 1 chunk +2 lines, -260 lines 0 comments Download
M webrtc/p2p/base/session.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/session.cc View 4 chunks +1 line, -8 lines 0 comments Download
M webrtc/p2p/base/transport.h View 7 chunks +1 line, -11 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 8 chunks +1 line, -84 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 12 chunks +15 lines, -27 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 2 chunks +9 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportdescription.h View 4 chunks +5 lines, -22 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 4 chunks +5 lines, -38 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 7 chunks +23 lines, -132 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/p2p/client/connectivitychecker.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/httpportallocator.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 19 chunks +4 lines, -57 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pthatcher1
Can you look at this re-re-land?
5 years, 4 months ago (2015-08-21 17:43:23 UTC) #2
guoweis_webrtc
On 2015/08/21 17:43:23, pthatcher1 wrote: > Can you look at this re-re-land? this is rather ...
5 years, 4 months ago (2015-08-21 22:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303393002/20001
5 years, 4 months ago (2015-08-21 22:41:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/460)
5 years, 4 months ago (2015-08-21 22:42:54 UTC) #7
pthatcher1
5 years, 4 months ago (2015-08-22 03:46:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2159b89fa2cb55beeef38f72bd45e217f3d33d4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698