Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: webrtc/p2p/base/candidate.h

Issue 1303393002: Reland "Remove GICE (gone forever!) and PORTALLOCATOR_ENABLE_SHARED_UFRAG (enabled forever)." becau… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add memcheck suppression Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/valgrind-webrtc/memcheck/suppressions.txt ('k') | webrtc/p2p/base/constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/candidate.h
diff --git a/webrtc/p2p/base/candidate.h b/webrtc/p2p/base/candidate.h
index 66b0ab04b38fd41a1622dd915686b7d4465f252d..2655c1b26c2b02639550cb3d88938274b7b62c79 100644
--- a/webrtc/p2p/base/candidate.h
+++ b/webrtc/p2p/base/candidate.h
@@ -84,10 +84,8 @@ class Candidate {
uint32 priority() const { return priority_; }
void set_priority(const uint32 priority) { priority_ = priority; }
-// void set_type_preference(uint32 type_preference) {
-// priority_ = GetPriority(type_preference);
-// }
-
+ // TODO(pthatcher): Remove once Chromium's jingle/glue/utils.cc
+ // doesn't use it.
// Maps old preference (which was 0.0-1.0) to match priority (which
// is 0-2^32-1) to to match RFC 5245, section 4.1.2.1. Also see
// https://docs.google.com/a/google.com/document/d/
@@ -97,6 +95,8 @@ class Candidate {
return static_cast<float>(((priority_ >> 24) * 100 / 127) / 100.0);
}
+ // TODO(pthatcher): Remove once Chromium's jingle/glue/utils.cc
+ // doesn't use it.
void set_preference(float preference) {
// Limiting priority to UINT_MAX when value exceeds uint32 max.
// This can happen for e.g. when preference = 3.
« no previous file with comments | « tools/valgrind-webrtc/memcheck/suppressions.txt ('k') | webrtc/p2p/base/constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698