Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1296103002: Delete unused function SetSessionError. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/trunk/talk.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete unused function SetSessionError. https://webrtc-codereview.appspot.com/47589004/ remove the use. BUG=505316 Moved to https://codereview.webrtc.org/1299703002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M session/media/channel.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Nico
5 years, 4 months ago (2015-08-16 01:30:17 UTC) #2
Sergey Ulanov
lgtm
5 years, 4 months ago (2015-08-16 22:49:25 UTC) #3
Nico
Thanks! How do I land this? `git cl land` says "Fetching pending ref refs/pending/heads/master... fatal: ...
5 years, 4 months ago (2015-08-17 04:04:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296103002/1
5 years, 4 months ago (2015-08-17 04:05:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/5081) linux on tryserver.webrtc (JOB_FAILED, ...
5 years, 4 months ago (2015-08-17 04:05:35 UTC) #8
Nico
Ping on """Thanks! How do I land this? `git cl land` says "Fetching pending ref ...
5 years, 4 months ago (2015-08-17 17:01:28 UTC) #9
Nico
Trying again at https://codereview.webrtc.org/1299703002 :-)
5 years, 4 months ago (2015-08-17 18:06:24 UTC) #10
pthatcher1
5 years, 4 months ago (2015-08-19 21:44:45 UTC) #12
Message was sent while issue was closed.
It looks like it has already been removed:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

Powered by Google App Engine
This is Rietveld 408576698