Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1290033005: Revert of Revert "Remove CpuMonitor and related, unused, code." (Closed)

Created:
5 years, 4 months ago by tommi
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Revert "Remove CpuMonitor and related, unused, code." (patchset #1 id:1 of https://codereview.webrtc.org/1287913004/ ) Reason for revert: (retrying with my webrtc account...) The reason for reverting is: Re-landing the change that removes the CpuMonitor class after having fixed the build issue in Chromium.. Original issue's description: > Revert "Remove CpuMonitor and related, unused, code." > > This reverts commit 1a24012680f25440aa1d117373df2af14cdc2fc1. > > TBR=tommi@webrtc.org,pthatcher@webrtc.org > BUG= > > This breaks > http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux/builds/20148/steps/compile/logs/stdio > > Committed: https://chromium.googlesource.com/external/webrtc/+/a472e968c95fb14e63ec42f453551d0967573ea8 TBR=pthatcher@webrtc.org,guoweis@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/048e80cacab128280c37c3e0574873cde8544410 Cr-Commit-Position: refs/heads/master@{#9733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -586 lines) Patch
M talk/media/webrtc/webrtcvideoengine2.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/base/cpumonitor.h View 1 chunk +0 lines, -123 lines 0 comments Download
D webrtc/base/cpumonitor.cc View 1 chunk +0 lines, -423 lines 0 comments Download
D webrtc/base/fakecpumonitor.h View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi
Created Revert of Revert "Remove CpuMonitor and related, unused, code."
5 years, 4 months ago (2015-08-19 10:59:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290033005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290033005/1
5 years, 4 months ago (2015-08-19 10:59:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 11:00:01 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 11:00:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/048e80cacab128280c37c3e0574873cde8544410
Cr-Commit-Position: refs/heads/master@{#9733}

Powered by Google App Engine
This is Rietveld 408576698