Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1287913004: Revert "Remove CpuMonitor and related, unused, code." (Closed)

Created:
5 years, 4 months ago by guoweis_webrtc
Modified:
5 years, 4 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -7 lines) Patch
M talk/media/webrtc/webrtcvideoengine2.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/base_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A webrtc/base/cpumonitor.h View 1 chunk +123 lines, -0 lines 0 comments Download
A webrtc/base/cpumonitor.cc View 1 chunk +423 lines, -0 lines 0 comments Download
A + webrtc/base/fakecpumonitor.h View 1 chunk +19 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
guoweis_webrtc
Committed patchset #1 (id:1) manually as a472e968c95fb14e63ec42f453551d0967573ea8 (presubmit successful).
5 years, 4 months ago (2015-08-19 00:08:54 UTC) #1
guoweis_webrtc
On 2015/08/19 00:08:54, guoweis wrote: > Committed patchset #1 (id:1) manually as > a472e968c95fb14e63ec42f453551d0967573ea8 (presubmit ...
5 years, 4 months ago (2015-08-19 00:09:44 UTC) #2
tommi (sloooow) - chröme
On 2015/08/19 00:09:44, guoweis wrote: > On 2015/08/19 00:08:54, guoweis wrote: > > Committed patchset ...
5 years, 4 months ago (2015-08-19 08:38:27 UTC) #3
tommi (sloooow) - chröme
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/1296763007/ by tommi@chromium.org. ...
5 years, 4 months ago (2015-08-19 10:58:02 UTC) #4
tommi
5 years, 4 months ago (2015-08-19 10:59:38 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1290033005/ by tommi@webrtc.org.

The reason for reverting is: (retrying with my webrtc account...)
The reason for reverting is: Re-landing the change that removes the CpuMonitor
class after having fixed the build issue in Chromium...

Powered by Google App Engine
This is Rietveld 408576698