Move SystemInfo to rtc_base_approved and delete unused code.

Move SystemInfo to rtc_base_approved and delete unused code.

This cl removes a lot of unused functionality in SystemInfo and reduces dependencies.
There's duplicate functionality in this class and WebRTC's CpuInfo class, so I'm consolidating the two implementations.
The CpuInfo interface will still exist since it's being used from Chrome to initialize the core count before the sandbox is engaged.
With this change, the SystemInfo class will get the benefit too of this initialization.

NOTRY=true
(using no try due to a dead android try bot)

Committed: https://crrev.com/efefda6062f8bf844cc7a01c80c26461c834c5e7
Cr-Commit-Position: refs/heads/master@{#9743}

[tommi, 2015-08-19 09:09:35]

tommi@webrtc.org changed reviewers:
+ magjed@webrtc.org

[tommi, 2015-08-19 09:09:41]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 09:09:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286163003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286163003/1

[commit-bot: I haz the power, 2015-08-19 09:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 09:20:37]

Dry run: Try jobs failed on following builders:
  linux_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/8912)

[tommi, 2015-08-19 20:29:45]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 20:29:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286163003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286163003/1

[commit-bot: I haz the power, 2015-08-19 22:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 22:30:08]

Dry run: Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[magjed_webrtc, 2015-08-20 08:04:26]

lgtm

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc
File webrtc/base/systeminfo.cc (right):

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:99: if (!logical_cpus_)
thread safe?

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:110: DWORD_PTR process_mask = 0, system_mask = 0;
One declaration per line?

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:146: std::string cpu_vendor;
Remove this and just return the strings directly in the different sections?

[tommi, 2015-08-20 08:16:11]

Address comments

[tommi (sloooow) - chröme, 2015-08-20 08:16:19]

tommi@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2015-08-20 08:16:20]

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc
File webrtc/base/systeminfo.cc (right):

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:99: if (!logical_cpus_)
On 2015/08/20 08:04:26, magjed_webrtc wrote:
> thread safe?

No :( But that behavior is not introduced in this CL. In Chromium this is thread
safe in practice since the value is initialized before the rest of webrtc gets a
chance to do anything, but this code in isolation is not thread safe.

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:110: DWORD_PTR process_mask = 0, system_mask = 0;
On 2015/08/20 08:04:26, magjed_webrtc wrote:
> One declaration per line?

Done.

https://codereview.webrtc.org/1286163003/diff/1/webrtc/base/systeminfo.cc#new...
webrtc/base/systeminfo.cc:146: std::string cpu_vendor;
On 2015/08/20 08:04:26, magjed_webrtc wrote:
> Remove this and just return the strings directly in the different sections?

Done.

[tommi (sloooow) - chröme, 2015-08-20 08:16:37]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2015-08-20 08:16:37]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1286163003/#ps2 (title:
"Address comments")

[commit-bot: I haz the power, 2015-08-20 08:16:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286163003/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286163003/2

[commit-bot: I haz the power, 2015-08-20 10:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 10:17:00]

Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tommi (sloooow) - chröme, 2015-08-20 12:03:03]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2015-08-20 12:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286163003/2
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286163003/2

[commit-bot: I haz the power, 2015-08-20 12:04:14]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2015-08-20 12:04:27]

Patchset 2 (id:??) landed as
https://crrev.com/efefda6062f8bf844cc7a01c80c26461c834c5e7
Cr-Commit-Position: refs/heads/master@{#9743}