Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: webrtc/base/systeminfo_unittest.cc

Issue 1286163003: Move SystemInfo to rtc_base_approved and delete unused code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Address comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/systeminfo.cc ('k') | webrtc/system_wrappers/interface/cpu_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/systeminfo_unittest.cc
diff --git a/webrtc/base/systeminfo_unittest.cc b/webrtc/base/systeminfo_unittest.cc
index fec553582a3c0169381e868a76c1a70f824a42fd..b1fc65e09166643fe4299575668382cb876fa7c5 100644
--- a/webrtc/base/systeminfo_unittest.cc
+++ b/webrtc/base/systeminfo_unittest.cc
@@ -52,14 +52,6 @@ TEST(SystemInfoTest, GetCpuArchitecture) {
#endif
}
-// Tests Cpu Cache Size
-TEST(SystemInfoTest, CpuCacheSize) {
- rtc::SystemInfo info;
- LOG(LS_INFO) << "CpuCacheSize: " << info.GetCpuCacheSize();
- EXPECT_GE(info.GetCpuCacheSize(), 8192); // 8 KB min cache
- EXPECT_LE(info.GetCpuCacheSize(), 1024 * 1024 * 1024); // 1 GB max cache
-}
-
// Tests MachineModel is set. On Mac test machine model is known.
TEST(SystemInfoTest, MachineModelKnown) {
rtc::SystemInfo info;
@@ -86,22 +78,6 @@ TEST(SystemInfoTest, MachineModelKnown) {
}
}
-// Tests maximum cpu clockrate.
-TEST(SystemInfoTest, CpuMaxCpuSpeed) {
- rtc::SystemInfo info;
- LOG(LS_INFO) << "MaxCpuSpeed: " << info.GetMaxCpuSpeed();
- EXPECT_GT(info.GetMaxCpuSpeed(), 0);
- EXPECT_LT(info.GetMaxCpuSpeed(), 100000); // 100 Ghz
-}
-
-// Tests current cpu clockrate.
-TEST(SystemInfoTest, CpuCurCpuSpeed) {
- rtc::SystemInfo info;
- LOG(LS_INFO) << "MaxCurSpeed: " << info.GetCurCpuSpeed();
- EXPECT_GT(info.GetCurCpuSpeed(), 0);
- EXPECT_LT(info.GetMaxCpuSpeed(), 100000);
-}
-
// Tests physical memory size.
TEST(SystemInfoTest, MemorySize) {
rtc::SystemInfo info;
@@ -116,14 +92,6 @@ TEST(SystemInfoTest, MaxCpus) {
EXPECT_GT(info.GetMaxCpus(), 0);
}
-// Tests number of physical cpus available to the system.
-TEST(SystemInfoTest, MaxPhysicalCpus) {
- rtc::SystemInfo info;
- LOG(LS_INFO) << "MaxPhysicalCpus: " << info.GetMaxPhysicalCpus();
- EXPECT_GT(info.GetMaxPhysicalCpus(), 0);
- EXPECT_LE(info.GetMaxPhysicalCpus(), info.GetMaxCpus());
-}
-
// Tests number of logical cpus available to the process.
TEST(SystemInfoTest, CurCpus) {
rtc::SystemInfo info;
@@ -180,15 +148,3 @@ TEST(SystemInfoTest, CpuStepping) {
EXPECT_EQ(0, info.GetCpuStepping());
}
#endif // CPU_X86
-
-#if WEBRTC_WIN && !defined(EXCLUDE_D3D9)
-TEST(SystemInfoTest, GpuInfo) {
- rtc::SystemInfo info;
- rtc::SystemInfo::GpuInfo gi;
- EXPECT_TRUE(info.GetGpuInfo(&gi));
- LOG(LS_INFO) << "GpuDriver: " << gi.driver;
- EXPECT_FALSE(gi.driver.empty());
- LOG(LS_INFO) << "GpuDriverVersion: " << gi.driver_version;
- EXPECT_FALSE(gi.driver_version.empty());
-}
-#endif
« no previous file with comments | « webrtc/base/systeminfo.cc ('k') | webrtc/system_wrappers/interface/cpu_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698