Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1282413002: Removing DtlsIdentityService[Interface] which has been replaced by DtlsIdentityStore[Interface/Impl] (Closed)

Created:
5 years, 4 months ago by hbos
Modified:
5 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing DtlsIdentityService[Interface] which has been replaced by DtlsIdentityStore[Interface/Impl]. This is CL is part of an effort to land https://codereview.webrtc.org/1176383004 without breaking Chromium. See bug for more information. BUG=webrtc:4899 Committed: https://crrev.com/c558af854f5f14be49652b684d3e2c328fb071d7 Cr-Commit-Position: refs/heads/master@{#9705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M talk/app/webrtc/dtlsidentitystore.h View 2 chunks +0 lines, -18 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 2 chunks +0 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hbos
PTAL tommi.
5 years, 4 months ago (2015-08-13 12:04:13 UTC) #2
tommi
lgtm
5 years, 4 months ago (2015-08-13 12:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282413002/1
5 years, 4 months ago (2015-08-13 14:05:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 15:29:02 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 15:29:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c558af854f5f14be49652b684d3e2c328fb071d7
Cr-Commit-Position: refs/heads/master@{#9705}

Powered by Google App Engine
This is Rietveld 408576698