Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2021)

Unified Diff: talk/app/webrtc/dtlsidentitystore.h

Issue 1282413002: Removing DtlsIdentityService[Interface] which has been replaced by DtlsIdentityStore[Interface/Impl] (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/peerconnectioninterface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/dtlsidentitystore.h
diff --git a/talk/app/webrtc/dtlsidentitystore.h b/talk/app/webrtc/dtlsidentitystore.h
index 6282870cfd8f40b9493ac78d4bcb1bdcd453b87b..1e15afb5f07973a5259b55e6661768d05ce8760a 100644
--- a/talk/app/webrtc/dtlsidentitystore.h
+++ b/talk/app/webrtc/dtlsidentitystore.h
@@ -44,23 +44,6 @@ class SSLIdentity;
class Thread;
// Used to receive callbacks of DTLS identity requests.
-class DTLSIdentityRequestObserver : public rtc::RefCountInterface {
- public:
- virtual void OnFailure(int error) = 0;
- // TODO(jiayl): Unify the OnSuccess method once Chrome code is updated.
- virtual void OnSuccess(const std::string& der_cert,
- const std::string& der_private_key) = 0;
- // |identity| is a scoped_ptr because rtc::SSLIdentity is not copyable and the
- // client has to get the ownership of the object to make use of it.
- virtual void OnSuccessWithIdentityObj(
- rtc::scoped_ptr<rtc::SSLIdentity> identity) = 0;
-
- protected:
- virtual ~DTLSIdentityRequestObserver() {}
-};
-
-// TODO(hbos): To replace DTLSIdentityRequestObserver.
-// Used to receive callbacks of DTLS identity requests.
class DtlsIdentityRequestObserver : public rtc::RefCountInterface {
public:
virtual void OnFailure(int error) = 0;
@@ -75,7 +58,6 @@ class DtlsIdentityRequestObserver : public rtc::RefCountInterface {
virtual ~DtlsIdentityRequestObserver() {}
};
-// TODO(hbos): To be implemented.
// This interface defines an in-memory DTLS identity store, which generates DTLS
// identities.
// APIs calls must be made on the signaling thread and the callbacks are also
« no previous file with comments | « no previous file | talk/app/webrtc/peerconnectioninterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698