Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: talk/app/webrtc/umametrics.h

Issue 1277263002: Add instrumentation to track the IceEndpointType. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/umametrics.h
diff --git a/talk/app/webrtc/umametrics.h b/talk/app/webrtc/umametrics.h
index bb9e05230d35cb0cb7dff3de24515625cd30a6f9..274a62e6ce52ee4a7ce2f8b8b42a1f4d88a09d0a 100644
--- a/talk/app/webrtc/umametrics.h
+++ b/talk/app/webrtc/umametrics.h
@@ -32,6 +32,14 @@
namespace webrtc {
+// Used to specify which enum counter type we're incrementing in
+// MetricsObserverInterface::IncrementEnumCounter.
+enum PeerConnectionEnumCounterType {
+ kPeerConnectionEnumCounter_IceEndpointTypeUDP,
juberti1 2015/08/14 21:26:04 UDP -> Udp TCP -> Tcp Can you add comments explai
+ kPeerConnectionEnumCounter_IceEndpointTypeTCP,
+ kPeerConnectionEnumCounter_Max
+};
+
// Currently this contains information related to WebRTC network/transport
// information.
@@ -77,6 +85,28 @@ enum PeerConnectionMetricsName {
// TODO(guoweis): Keep previous name here until all references are renamed.
typedef PeerConnectionMetricsName PeerConnectionUMAMetricsName;
+// The IceEndpointType has the format of <local_endpoint>_<remote_endpoint>. It
+// is recorded on the BestConnection when we have the first OnTransportCompleted
+// signaled.
+enum IceEndpointType {
juberti1 2015/08/14 21:26:04 I think this should be IceCandidatePairType?
+ kIceEndpoint_Host_Host,
+ kIceEndpoint_Host_Srflx,
+ kIceEndpoint_Host_Relay,
+ kIceEndpoint_Host_Prflx,
+ kIceEndpoint_Srflx_Host,
+ kIceEndpoint_Srflx_Srflx,
+ kIceEndpoint_Srflx_Relay,
+ kIceEndpoint_Srflx_Prflx,
+ kIceEndpoint_Relay_Host,
+ kIceEndpoint_Relay_Srflx,
+ kIceEndpoint_Relay_Relay,
+ kIceEndpoint_Relay_Prflx,
+ kIceEndpoint_Prflx_Host,
+ kIceEndpoint_Prflx_Srflx,
+ kIceEndpoint_Prflx_Relay,
+ kIceEndpoint_Max
+};
+
} // namespace webrtc
#endif // TALK_APP_WEBRTC_UMA6METRICS_H_

Powered by Google App Engine
This is Rietveld 408576698