Add instrumentation to track the IceEndpointType.

talk/app/webrtc/umametrics.h

 /*
  * libjingle
  * Copyright 2014 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 14 matching lines @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 // This file contains enums related to IPv4/IPv6 metrics.
 
 #ifndef TALK_APP_WEBRTC_UMAMETRICS_H_
 #define TALK_APP_WEBRTC_UMAMETRICS_H_
 
 namespace webrtc {
 
+// Used to specify which enum counter type we're incrementing in
+// MetricsObserverInterface::IncrementEnumCounter.
+enum PeerConnectionEnumCounterType {
+  kPeerConnectionEnumCounter_IceEndpointTypeUDP,

[juberti1, 2015/08/14 21:26:04]

UDP -> Udp
TCP -> Tcp

Can you add comments explaining what these counters will be measuring (and why
we need to measure udp/tcp separately?)

+  kPeerConnectionEnumCounter_IceEndpointTypeTCP,
+  kPeerConnectionEnumCounter_Max
+};
+
 // Currently this contains information related to WebRTC network/transport
 // information.
 
 // The difference between PeerConnectionMetricsCounter and
 // PeerConnectionMetricsName is that the "Counter" is only counting the
 // occurrences of events, while "Name" has a value associated with it which is
 // used to form a histogram.
 
 // This enum is backed by Chromium's histograms.xml,
 // chromium/src/tools/metrics/histograms/histograms.xml
@@ skipping 25 matching lines @@
   kVideoSrtpCipher,         // Name of SRTP cipher used in video channel.
   kVideoSslCipher,          // Name of SSL cipher used in video channel.
   kDataSrtpCipher,          // Name of SRTP cipher used in data channel.
   kDataSslCipher,           // Name of SSL cipher used in data channel.
   kPeerConnectionMetricsName_Max
 };
 
 // TODO(guoweis): Keep previous name here until all references are renamed.
 typedef PeerConnectionMetricsName PeerConnectionUMAMetricsName;
 
+// The IceEndpointType has the format of <local_endpoint>_<remote_endpoint>. It
+// is recorded on the BestConnection when we have the first OnTransportCompleted
+// signaled.
+enum IceEndpointType {

[juberti1, 2015/08/14 21:26:04]

I think this should be IceCandidatePairType?

+  kIceEndpoint_Host_Host,
+  kIceEndpoint_Host_Srflx,
+  kIceEndpoint_Host_Relay,
+  kIceEndpoint_Host_Prflx,
+  kIceEndpoint_Srflx_Host,
+  kIceEndpoint_Srflx_Srflx,
+  kIceEndpoint_Srflx_Relay,
+  kIceEndpoint_Srflx_Prflx,
+  kIceEndpoint_Relay_Host,
+  kIceEndpoint_Relay_Srflx,
+  kIceEndpoint_Relay_Relay,
+  kIceEndpoint_Relay_Prflx,
+  kIceEndpoint_Prflx_Host,
+  kIceEndpoint_Prflx_Srflx,
+  kIceEndpoint_Prflx_Relay,
+  kIceEndpoint_Max
+};
+
 }  // namespace webrtc
 
 #endif  // TALK_APP_WEBRTC_UMA6METRICS_H_