Issue 1270333002: Get rid of media_engine_ from BaseChannel; only VoiceChannel needs it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1270333002: Get rid of media_engine_ from BaseChannel; only VoiceChannel needs it. (Closed)

Created:
5 years, 4 months ago by the sun

Modified:
5 years, 4 months ago

Reviewers:
tommi

CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Get rid of media_engine_ from BaseChannel; only VoiceChannel needs it. BUG=webrtc:4690 R=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/0c0226408dc6f42abc2cd53cab2de02d3ee610d7

Patch Set 1 #

Patch Set 2 : Drop unrelated file #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -25 lines)			Patch
M	talk/app/webrtc/statscollector_unittest.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	talk/session/media/channel.h	View	5 chunks	+5 lines, -7 lines	0 comments	Download
M	talk/session/media/channel.cc	View	5 chunks	+5 lines, -8 lines	0 comments	Download
M	talk/session/media/channel_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	talk/session/media/channelmanager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

the sun

5 years, 4 months ago (2015-08-05 10:26:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
0c0226408dc6f42abc2cd53cab2de02d3ee610d7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages