talk/session/media/channelmanager.cc - Issue 1270333002: Get rid of media_engine_ from BaseChannel; only VoiceChannel needs it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/session/media/channelmanager.cc

Issue 1270333002: Get rid of media_engine_ from BaseChannel; only VoiceChannel needs it. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/session/media/channelmanager.cc

diff --git a/talk/session/media/channelmanager.cc b/talk/session/media/channelmanager.cc

index 52116ddb39c7b2298c251546468764dd2fe066d9..f3c43d03a9381c651a29ba50ca8d2600733a54cc 100644

--- a/talk/session/media/channelmanager.cc

+++ b/talk/session/media/channelmanager.cc

@@ -422,7 +422,7 @@ VideoChannel* ChannelManager::CreateVideoChannel_w(

return NULL;

VideoChannel* video_channel = new VideoChannel(

- worker_thread_, media_engine_.get(), media_channel,

+ worker_thread_, media_channel,

session, content_name, rtcp);

if (!video_channel->Init()) {

delete video_channel;

« no previous file with comments | « talk/session/media/channel_unittest.cc ('k') | no next file » | no next file with comments »