Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: talk/media/base/videoengine_unittest.h

Issue 1269863005: MediaController/Call instantiation. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove redundant reset(nullptr) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/mediaengine.h ('k') | talk/media/webrtc/webrtcvideoengine2.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/videoengine_unittest.h
diff --git a/talk/media/base/videoengine_unittest.h b/talk/media/base/videoengine_unittest.h
index c74479c7da718df63896e8d2bdf0ea2383f7e3b3..9e6b227011abd36366c1b93289c1d4cdb4cd5300 100644
--- a/talk/media/base/videoengine_unittest.h
+++ b/talk/media/base/videoengine_unittest.h
@@ -36,9 +36,11 @@
#include "talk/media/base/fakevideorenderer.h"
#include "talk/media/base/mediachannel.h"
#include "talk/media/base/streamparams.h"
+#include "talk/media/webrtc/fakewebrtccall.h"
#include "webrtc/base/bytebuffer.h"
#include "webrtc/base/gunit.h"
#include "webrtc/base/timeutils.h"
+#include "webrtc/call.h"
#define EXPECT_FRAME_WAIT(c, w, h, t) \
EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
@@ -96,7 +98,7 @@ inline int TimeBetweenSend(const cricket::VideoCodec& codec) {
template<class T>
class VideoEngineOverride : public T {
public:
- VideoEngineOverride() : T(nullptr) {
+ VideoEngineOverride() : T() {
}
virtual ~VideoEngineOverride() {
}
@@ -448,6 +450,9 @@ template<class E, class C>
class VideoMediaChannelTest : public testing::Test,
public sigslot::has_slots<> {
protected:
+ VideoMediaChannelTest<E, C>()
+ : call_(webrtc::Call::Create(webrtc::Call::Config())) {}
+
virtual cricket::VideoCodec DefaultCodec() = 0;
virtual cricket::StreamParams DefaultSendStreamParams() {
@@ -457,7 +462,8 @@ class VideoMediaChannelTest : public testing::Test,
virtual void SetUp() {
cricket::Device device("test", "device");
engine_.Init();
- channel_.reset(engine_.CreateChannel(cricket::VideoOptions(), NULL));
+ channel_.reset(
+ engine_.CreateChannel(call_.get(), cricket::VideoOptions()));
EXPECT_TRUE(channel_.get() != NULL);
ConnectVideoChannelError();
network_interface_.SetDestination(channel_.get());
@@ -1867,6 +1873,7 @@ class VideoMediaChannelTest : public testing::Test,
EXPECT_TRUE(channel_->RemoveRecvStream(kSsrc + 2));
}
+ const rtc::scoped_ptr<webrtc::Call> call_;
VideoEngineOverride<E> engine_;
rtc::scoped_ptr<cricket::FakeVideoCapturer> video_capturer_;
rtc::scoped_ptr<cricket::FakeVideoCapturer> video_capturer_2_;
« no previous file with comments | « talk/media/base/mediaengine.h ('k') | talk/media/webrtc/webrtcvideoengine2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698