Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: talk/media/base/mediaengine.h

Issue 1269863005: MediaController/Call instantiation. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Remove redundant reset(nullptr) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/media/base/mediachannel.h ('k') | talk/media/base/videoengine_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/media/base/mediaengine.h
diff --git a/talk/media/base/mediaengine.h b/talk/media/base/mediaengine.h
index 339251f90649a24a58cbf60f6efe4daf6f9c8fde..08addc46400553df42bc9946bf9f118a63d0507c 100644
--- a/talk/media/base/mediaengine.h
+++ b/talk/media/base/mediaengine.h
@@ -32,8 +32,6 @@
#include <CoreAudio/CoreAudio.h>
#endif
-#include <limits.h>
-
#include <string>
#include <vector>
@@ -51,6 +49,11 @@
#define DISABLE_MEDIA_ENGINE_FACTORY
#endif
+namespace webrtc {
+class Call;
+class VoiceEngine;
+}
+
namespace cricket {
class VideoCapturer;
@@ -73,15 +76,19 @@ class MediaEngineInterface {
virtual void Terminate() = 0;
// Returns what the engine is capable of, as a set of Capabilities, above.
virtual int GetCapabilities() = 0;
+ // TODO(solenberg): Remove once VoE API refactoring is done.
+ virtual webrtc::VoiceEngine* GetVoE() = 0;
// MediaChannel creation
// Creates a voice media channel. Returns NULL on failure.
- virtual VoiceMediaChannel* CreateChannel(const AudioOptions& options) = 0;
+ virtual VoiceMediaChannel* CreateChannel(
+ webrtc::Call* call,
+ const AudioOptions& options) = 0;
// Creates a video media channel, paired with the specified voice channel.
// Returns NULL on failure.
virtual VideoMediaChannel* CreateVideoChannel(
- const VideoOptions& options,
- VoiceMediaChannel* voice_media_channel) = 0;
+ webrtc::Call* call,
+ const VideoOptions& options) = 0;
// Configuration
// Gets global audio options.
@@ -162,7 +169,6 @@ class MediaEngineFactory {
template<class VOICE, class VIDEO>
class CompositeMediaEngine : public MediaEngineInterface {
public:
- CompositeMediaEngine() : video_(&voice_) {}
virtual ~CompositeMediaEngine() {}
virtual bool Init(rtc::Thread* worker_thread) {
if (!voice_.Init(worker_thread))
@@ -177,12 +183,16 @@ class CompositeMediaEngine : public MediaEngineInterface {
virtual int GetCapabilities() {
return (voice_.GetCapabilities() | video_.GetCapabilities());
}
- virtual VoiceMediaChannel* CreateChannel(const AudioOptions& options) {
- return voice_.CreateChannel(options);
+ virtual webrtc::VoiceEngine* GetVoE() {
+ return voice_.GetVoE();
+ }
+ virtual VoiceMediaChannel* CreateChannel(webrtc::Call* call,
+ const AudioOptions& options) {
+ return voice_.CreateChannel(call, options);
}
- virtual VideoMediaChannel* CreateVideoChannel(const VideoOptions& options,
- VoiceMediaChannel* channel) {
- return video_.CreateChannel(options, channel);
+ virtual VideoMediaChannel* CreateVideoChannel(webrtc::Call* call,
+ const VideoOptions& options) {
+ return video_.CreateChannel(call, options);
}
virtual AudioOptions GetAudioOptions() const {
« no previous file with comments | « talk/media/base/mediachannel.h ('k') | talk/media/base/videoengine_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698