Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/statscollector_unittest.cc

Index: talk/app/webrtc/statscollector_unittest.cc
diff --git a/talk/app/webrtc/statscollector_unittest.cc b/talk/app/webrtc/statscollector_unittest.cc
index ab9181f4875d78a5904e94201e32e1915fe1dcdd..bb9adee45db5e19418984a2304464298d51fc816 100644
--- a/talk/app/webrtc/statscollector_unittest.cc
+++ b/talk/app/webrtc/statscollector_unittest.cc
@@ -656,7 +656,10 @@ class StatsCollectorTest : public testing::Test {
         transport_stats;
 
     // Fake certificates to report.
-    rtc::FakeSSLIdentity local_identity(local_cert);
+    rtc::scoped_refptr<webrtc::DtlsCertificate> local_dtlscert =
+        webrtc::DtlsCertificate::Create(
+            rtc::scoped_ptr<rtc::FakeSSLIdentity>(
+                new rtc::FakeSSLIdentity(local_cert)).Pass());
     rtc::scoped_ptr<rtc::FakeSSLCertificate> remote_cert_copy(
         remote_cert.GetReference());
 
@@ -666,7 +669,7 @@ class StatsCollectorTest : public testing::Test {
             session_.signaling_thread(),
             session_.worker_thread(),
             transport_stats.content_name));
-    transport->SetIdentity(&local_identity);
+    transport->SetCertificate(local_dtlscert);

[Henrik Grunell WebRTC, 2015/08/12 14:46:30]

As we talked about offline, it would be nice to split this CL in three that (1)
adds these new functions further down the chain (that are supposed to be
replaced), (2) starts using the new ones, and (3) removes the old functions. But
I'm OK with a big CL if it's too much work.

[hbos, 2015/08/14 14:09:39]

If I see this clearly I think adding support for both SSLIdentity* and
scoped_refptr<DtlsCertificate> at the same time with multiple functions in a
series of CLs is not only significantly more work, but would lead to more
difficult code changes and be more error prone as well and would not be a very
"clean" switch.

If the reviewers feel like this CL should be split up I instead suggest
replacing a few of the functions at a time per CL. This should be possible if
done in the correct order.

For example if we have a function call chain like so: A(SSLIdentity*) ->
B(SSLIdentity*) -> C(SSLIdentity*). One could replace A and B to take
scoped_refptr<DtlsCertificate> before updating C in a later CL, because the
DtlsCertificate contains the SSLIdentity* pointer.
Like so: B(scoped_refptr<DtlsCertificate> cert) { ... C(cert->identity(); ... }.

[Henrik Grunell WebRTC, 2015/08/18 14:25:11]

Acknowledged.

     cricket::FakeTransportChannel* channel =
         static_cast<cricket::FakeTransportChannel*>(
             transport->CreateChannel(channel_stats.component));