Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/statscollector_unittest.cc

 /*
  * libjingle
  * Copyright 2014 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 638 matching lines @@
 
     cricket::TransportStats transport_stats;
     transport_stats.content_name = "audio";
     transport_stats.channel_stats.push_back(channel_stats);
 
     cricket::SessionStats session_stats;
     session_stats.transport_stats[transport_stats.content_name] =
         transport_stats;
 
     // Fake certificates to report.
-    rtc::FakeSSLIdentity local_identity(local_cert);
+    rtc::scoped_refptr<webrtc::DtlsCertificate> local_dtlscert =
+        webrtc::DtlsCertificate::Create(
+            rtc::scoped_ptr<rtc::FakeSSLIdentity>(
+                new rtc::FakeSSLIdentity(local_cert)).Pass());
     rtc::scoped_ptr<rtc::FakeSSLCertificate> remote_cert_copy(
         remote_cert.GetReference());
 
     // Fake transport object.
     rtc::scoped_ptr<cricket::FakeTransport> transport(
         new cricket::FakeTransport(
             session_.signaling_thread(),
             session_.worker_thread(),
             transport_stats.content_name));
-    transport->SetIdentity(&local_identity);
+    transport->SetCertificate(local_dtlscert);

[Henrik Grunell WebRTC, 2015/08/12 14:46:30]

As we talked about offline, it would be nice to split this CL in three that (1)
adds these new functions further down the chain (that are supposed to be
replaced), (2) starts using the new ones, and (3) removes the old functions. But
I'm OK with a big CL if it's too much work.

[hbos, 2015/08/14 14:09:39]

If I see this clearly I think adding support for both SSLIdentity* and
scoped_refptr<DtlsCertificate> at the same time with multiple functions in a
series of CLs is not only significantly more work, but would lead to more
difficult code changes and be more error prone as well and would not be a very
"clean" switch.

If the reviewers feel like this CL should be split up I instead suggest
replacing a few of the functions at a time per CL. This should be possible if
done in the correct order.

For example if we have a function call chain like so: A(SSLIdentity*) ->
B(SSLIdentity*) -> C(SSLIdentity*). One could replace A and B to take
scoped_refptr<DtlsCertificate> before updating C in a later CL, because the
DtlsCertificate contains the SSLIdentity* pointer.
Like so: B(scoped_refptr<DtlsCertificate> cert) { ... C(cert->identity(); ... }.

[Henrik Grunell WebRTC, 2015/08/18 14:25:11]

Acknowledged.

     cricket::FakeTransportChannel* channel =
         static_cast<cricket::FakeTransportChannel*>(
             transport->CreateChannel(channel_stats.component));
     EXPECT_FALSE(channel == NULL);
     channel->SetRemoteCertificate(remote_cert_copy.get());
 
     // Configure MockWebRtcSession
     EXPECT_CALL(session_, GetTransport(transport_stats.content_name))
       .WillRepeatedly(Return(transport.get()));
     EXPECT_CALL(session_, GetTransportStats(_))
@@ skipping 1022 matching lines @@
   cricket::VoiceSenderInfo new_voice_sender_info;
   InitVoiceSenderInfo(&new_voice_sender_info);
   cricket::VoiceMediaInfo new_stats_read;
   reports.clear();
   SetupAndVerifyAudioTrackStats(
       new_audio_track.get(), stream_.get(), &stats, &voice_channel, kVcName,
       media_channel, &new_voice_sender_info, NULL, &new_stats_read, &reports);
 }
 
 }  // namespace webrtc