Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/dtlscertificate.cc

Index: talk/app/webrtc/dtlscertificate.cc
diff --git a/talk/app/webrtc/audiotrackrenderer.cc b/talk/app/webrtc/dtlscertificate.cc
similarity index 66%
copy from talk/app/webrtc/audiotrackrenderer.cc
copy to talk/app/webrtc/dtlscertificate.cc
index 264a3cb73485201c933e4082c036c9a0dce6c4f4..e48ce3e3f68dcf57cac12b919a24c3602ee45fd6 100644
--- a/talk/app/webrtc/audiotrackrenderer.cc
+++ b/talk/app/webrtc/dtlscertificate.cc
@@ -1,6 +1,6 @@
 /*
  * libjingle
- * Copyright 2013 Google Inc.
+ * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
@@ -25,25 +25,33 @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "talk/app/webrtc/audiotrackrenderer.h"
-#include "webrtc/base/common.h"
+#include "talk/app/webrtc/dtlscertificate.h"
+
+#include "webrtc/base/checks.h"
 
 namespace webrtc {
 
-AudioTrackRenderer::AudioTrackRenderer() : channel_id_(-1) {
+rtc::scoped_refptr<DtlsCertificate> DtlsCertificate::Create(
+    rtc::scoped_ptr<rtc::SSLIdentity> identity) {
+  // TODO(hbos): |expires| should be specified (what is the right type for
+  // date?), and maybe tied to the identity generation?

[Henrik Grunell WebRTC, 2015/08/12 14:46:29]

Do you plan on fixing the todo before landing? Not sure about time handling in
webrtc, does timeutils.h give any hints?

[hbos, 2015/08/14 14:09:38]

That hints for an integer type, but I think blink uses double so maybe a
conversion is needed if so. But considering it's just there as a dummy field for
now I'll delete it until when needed in the future.

+  return new rtc::RefCountedObject<DtlsCertificate>(identity.release(), 0.0);

[Henrik Grunell WebRTC, 2015/08/12 14:46:29]

identity.Pass()

[hbos, 2015/08/14 14:09:38]

The DtlsCertificate constructor takes SSLIdentity*, not scoped_ptr<SSLIdentity>,
so I can't Pass().
The reason for the constructor not taking scoped_ptr<SSLIdentity> is that the
RefCountedObject<T> constructor invokes the DtlsCertificate constructor like so:
T(p1, p2), without using .Pass() (so it does not compile with p1 being
scoped_ptr).
The non-usage of scoped_ptr for our identity is limited to this protected
constructor though and not visible to the outside.

+}
+
+DtlsCertificate::DtlsCertificate(rtc::SSLIdentity* identity, double expires)
+    : identity_(identity), expires_(expires) {
+  DCHECK(identity_);
 }
 
-AudioTrackRenderer::~AudioTrackRenderer() {
+DtlsCertificate::~DtlsCertificate() {
 }
 
-void AudioTrackRenderer::AddChannel(int channel_id) {
-  ASSERT(channel_id_ == -1 || channel_id_ == channel_id);
-  channel_id_ = channel_id;
+rtc::SSLIdentity* DtlsCertificate::identity() const {
+  return identity_.get();
 }
 
-void AudioTrackRenderer::RemoveChannel(int channel_id) {
-  ASSERT(channel_id_ == -1 || channel_id_ == channel_id);
-  channel_id_ = -1;
+double DtlsCertificate::expires() const {
+  return expires_;
 }
 
 }  // namespace webrtc