Added DtlsCertificate, a ref counted object owning an SSLIdentity

talk/app/webrtc/dtlscertificate.cc

 /*
  * libjingle
- * Copyright 2013 Google Inc.
+ * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
  *     this list of conditions and the following disclaimer in the documentation
  *     and/or other materials provided with the distribution.
  *  3. The name of the author may not be used to endorse or promote products
  *     derived from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
  * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "talk/app/webrtc/audiotrackrenderer.h"
-#include "webrtc/base/common.h"
+#include "talk/app/webrtc/dtlscertificate.h"
+
+#include "webrtc/base/checks.h"
 
 namespace webrtc {
 
-AudioTrackRenderer::AudioTrackRenderer() : channel_id_(-1) {
+rtc::scoped_refptr<DtlsCertificate> DtlsCertificate::Create(
+    rtc::scoped_ptr<rtc::SSLIdentity> identity) {
+  // TODO(hbos): |expires| should be specified (what is the right type for
+  // date?), and maybe tied to the identity generation?

[Henrik Grunell WebRTC, 2015/08/12 14:46:29]

Do you plan on fixing the todo before landing? Not sure about time handling in
webrtc, does timeutils.h give any hints?

[hbos, 2015/08/14 14:09:38]

That hints for an integer type, but I think blink uses double so maybe a
conversion is needed if so. But considering it's just there as a dummy field for
now I'll delete it until when needed in the future.

+  return new rtc::RefCountedObject<DtlsCertificate>(identity.release(), 0.0);

[Henrik Grunell WebRTC, 2015/08/12 14:46:29]

identity.Pass()

[hbos, 2015/08/14 14:09:38]

The DtlsCertificate constructor takes SSLIdentity*, not scoped_ptr<SSLIdentity>,
so I can't Pass().
The reason for the constructor not taking scoped_ptr<SSLIdentity> is that the
RefCountedObject<T> constructor invokes the DtlsCertificate constructor like so:
T(p1, p2), without using .Pass() (so it does not compile with p1 being
scoped_ptr).
The non-usage of scoped_ptr for our identity is limited to this protected
constructor though and not visible to the outside.

 }
 
-AudioTrackRenderer::~AudioTrackRenderer() {
+DtlsCertificate::DtlsCertificate(rtc::SSLIdentity* identity, double expires)
+    : identity_(identity), expires_(expires) {
+  DCHECK(identity_);
 }
 
-void AudioTrackRenderer::AddChannel(int channel_id) {
-  ASSERT(channel_id_ == -1 || channel_id_ == channel_id);
-  channel_id_ = channel_id;
+DtlsCertificate::~DtlsCertificate() {
 }
 
-void AudioTrackRenderer::RemoveChannel(int channel_id) {
-  ASSERT(channel_id_ == -1 || channel_id_ == channel_id);
-  channel_id_ = -1;
+rtc::SSLIdentity* DtlsCertificate::identity() const {
+  return identity_.get();
+}
+
+double DtlsCertificate::expires() const {
+  return expires_;
 }
 
 }  // namespace webrtc