Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268383002: Use RtcpPacket to send SLI in RtcpSender (Closed)

Created:
5 years, 4 months ago by sprang_webrtc
Modified:
5 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use RtcpPacket to send SLI in RtcpSender BUG=webrtc:2450 Committed: https://crrev.com/0365a27f56aa2d2376d2f356bf70d161c3450244 Cr-Commit-Position: refs/heads/master@{#9695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -25 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 chunk +10 lines, -23 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sprang_webrtc
5 years, 4 months ago (2015-08-05 09:58:32 UTC) #2
åsapersson
lgtm
5 years, 4 months ago (2015-08-10 11:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268383002/1
5 years, 4 months ago (2015-08-10 11:59:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-10 13:59:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268383002/1
5 years, 4 months ago (2015-08-11 08:02:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 08:02:41 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 08:02:56 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0365a27f56aa2d2376d2f356bf70d161c3450244
Cr-Commit-Position: refs/heads/master@{#9695}

Powered by Google App Engine
This is Rietveld 408576698