Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc

Issue 1268383002: Use RtcpPacket to send SLI in RtcpSender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
diff --git a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
index 741b7ac0bd95fadc79e98159f3f95013a49aceb2..4fc89a9a84a7b454118a6938487e175a28a1e740 100644
--- a/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
+++ b/webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc
@@ -23,6 +23,7 @@
using namespace webrtc;
const uint64_t kTestPictureId = 12345678;
+const uint8_t kSliPictureId = 156;
class RtcpCallback : public RtcpIntraFrameObserver {
public:
@@ -38,7 +39,7 @@ class RtcpCallback : public RtcpIntraFrameObserver {
};
virtual void OnReceivedSLI(uint32_t ssrc,
uint8_t pictureId) {
- EXPECT_EQ(28, pictureId);
+ EXPECT_EQ(kSliPictureId & 0x3f, pictureId);
};
virtual void OnReceivedRPSI(uint32_t ssrc,
uint64_t pictureId) {
@@ -204,7 +205,7 @@ class RtpRtcpRtcpTest : public ::testing::Test {
TEST_F(RtpRtcpRtcpTest, RTCP_PLI_RPSI) {
EXPECT_EQ(0, module1->SendRTCPReferencePictureSelection(kTestPictureId));
- EXPECT_EQ(0, module1->SendRTCPSliceLossIndication(156));
+ EXPECT_EQ(0, module1->SendRTCPSliceLossIndication(kSliPictureId));
}
TEST_F(RtpRtcpRtcpTest, RTCP_CNAME) {
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698