Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1265823003: Fix a bug in computing audio delay on ios device. Converts seconds to (Closed)

Created:
5 years, 4 months ago by jiawei.ou
Modified:
5 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a bug in computing audio delay on ios device. Converts seconds to milliseconds by multiplying 1000 instead of dividing 1000. BUG= R=tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4de6622bccb0e8ba3dff9de26ca69e3adf7a4eba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
jiawei.ou
5 years, 4 months ago (2015-07-30 20:54:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265823003/1
5 years, 4 months ago (2015-08-04 17:40:38 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-04 19:40:49 UTC) #7
jiawei.ou
On 2015/07/30 20:54:19, jiawei.ou wrote: Is this getting reviewed?
5 years, 4 months ago (2015-08-07 17:15:49 UTC) #8
tkchin_webrtc
On 2015/08/07 17:15:49, jiawei.ou wrote: > On 2015/07/30 20:54:19, jiawei.ou wrote: > > Is this ...
5 years, 4 months ago (2015-08-07 17:21:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265823003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265823003/1
5 years, 4 months ago (2015-08-10 16:55:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 4 months ago (2015-08-10 18:56:02 UTC) #13
tkchin_webrtc
Committed patchset #1 (id:1) manually as 4de6622bccb0e8ba3dff9de26ca69e3adf7a4eba (presubmit successful).
5 years, 4 months ago (2015-08-10 20:25:01 UTC) #14
henrika_webrtc
5 years, 4 months ago (2015-08-17 09:11:03 UTC) #15
Message was sent while issue was closed.
May I ask how this issues was detected? Given that we always use the built-in
AEC; any error in delay estimates should in theory not affect the performance.

Powered by Google App Engine
This is Rietveld 408576698