Add QP stats for sent video streams to StatsReport.

Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is reported (all TL layers included). The QP for the highest resolution stream is reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=webrtc:3136

[åsapersson, 2015-08-10 09:06:30]

Patchset #2 (id:20001) has been deleted

[åsapersson, 2015-08-12 06:10:34]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[åsapersson, 2015-08-24 08:37:03]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org

[åsapersson, 2015-09-01 12:23:42]

asapersson@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-09-03 12:01:22]

lgtm

https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.h:135: std::map<uint32_t, QpCounters>
qp_counters_ GUARDED_BY(crit_);
Comment on what the uint32_t is, i.e., what this is a map from and to.

[åsapersson, 2015-09-03 14:40:48]

https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.h:135: std::map<uint32_t, QpCounters>
qp_counters_ GUARDED_BY(crit_);
On 2015/09/03 12:01:21, stefan-webrtc (holmer) wrote:
> Comment on what the uint32_t is, i.e., what this is a map from and to.

Done.

[pbos-webrtc, 2015-09-03 14:50:21]

lgtm

https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.h:135: // QP counters mapped by the SSRC.
s/the SSRC/SSRC

[åsapersson, 2015-09-03 15:13:24]

https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statist...
File webrtc/video/send_statistics_proxy.h (right):

https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statist...
webrtc/video/send_statistics_proxy.h:135: // QP counters mapped by the SSRC.
On 2015/09/03 14:50:21, pbos-webrtc wrote:
> s/the SSRC/SSRC

Done.

[stefan-webrtc, 2015-09-03 15:32:51]

lgtm

[åsapersson, 2015-09-04 06:28:34]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2015-09-04 06:28:35]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1264693003/#ps80001 (title:
"modified comment")

[commit-bot: I haz the power, 2015-09-04 06:28:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1264693003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1264693003/80001

[commit-bot: I haz the power, 2015-09-04 06:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 06:30:17]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/598)

[mflodman, 2015-09-08 11:42:38]

On 2015/09/04 06:30:17, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   presubmit on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/598)

My understanding was we agreed to log the decoded QP?

In case I remember that wrong, I'd like to log this as encoded qp and also add
the decoded qp. I think we should log what is actually displayed at the receive
side.

[åsapersson, 2015-09-08 12:27:40]

On 2015/09/08 11:42:38, mflodman wrote:
> On 2015/09/04 06:30:17, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   presubmit on tryserver.webrtc (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/598)
> 
> My understanding was we agreed to log the decoded QP?
> 
> In case I remember that wrong, I'd like to log this as encoded qp and also add
> the decoded qp. I think we should log what is actually displayed at the
receive
> side.

OK, I will log qp at the receive side. Updated metric name to be encoded qp.
Only log at receive side and skip this?

[åsapersson, 2015-10-23 08:41:07]

Patchset #6 (id:120001) has been deleted

[åsapersson, 2015-11-24 14:43:35]

Patchset #8 (id:180001) has been deleted

[åsapersson, 2015-11-24 14:45:06]

Description was changed from

==========
Add stats for average QP per frame for VP8 (for sent video streams):

"WebRTC.Video.Encoded.VP8.Qp"

BUG=chromium:512752
==========

to

==========
Add stats for average QP per frame for VP8 (for sent video streams):

"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-24 15:29:04]

Patchset #9 (id:210001) has been deleted

[åsapersson, 2015-11-25 08:19:09]

Description was changed from

==========
Add stats for average QP per frame for VP8 (for sent video streams):

"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for video sent streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 08:20:23]

Description was changed from

==========
Add QP stats for video sent streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 08:20:35]

Description was changed from

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
"WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 08:23:56]

Description was changed from

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP for a sent VP8 video stream is reported. QP range is
0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is
reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 09:06:33]

Description was changed from

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is
reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for the highest sent resolution
VP8 video stream is reported (all TL layers). QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 09:17:21]

Description was changed from

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for the highest sent resolution
VP8 video stream is reported (all TL layers). QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is
reported (all TL layers included). The QP for the highest resolution stream is
reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

[åsapersson, 2015-11-25 09:24:33]

Description was changed from

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is
reported (all TL layers included). The QP for the highest resolution stream is
reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=
==========

to

==========
Add QP stats for sent video streams to StatsReport for tracking video quality.

A running average of the QP (per-frame value) for a sent VP8 video stream is
reported (all TL layers included). The QP for the highest resolution stream is
reported. QP range is 0-127.

Add histogram stats for average QP per frame for VP8 (for sent video streams):
- "WebRTC.Video.Encoded.VP8.Qp"

BUG=webrtc:3136
==========

[åsapersson, 2015-11-25 11:21:25]

Patchset #10 (id:250001) has been deleted

[åsapersson, 2015-11-25 12:40:58]

asapersson@webrtc.org changed reviewers:
+ hta@webrtc.org

[åsapersson, 2015-11-25 12:41:44]

I have updated the CL to also add the QP to StatsReport, ptal.

Adding hta as a reviewer.

[åsapersson, 2015-11-25 15:35:24]

Patchset #11 (id:290001) has been deleted

[åsapersson, 2015-11-25 16:09:04]

Patchset #12 (id:330001) has been deleted

[åsapersson, 2015-11-25 16:09:12]

Patchset #11 (id:310001) has been deleted

[åsapersson, 2015-11-25 16:17:40]

Patchset #11 (id:350001) has been deleted

[åsapersson, 2015-11-26 08:38:21]

Patchset #11 (id:370001) has been deleted

[åsapersson, 2015-11-26 08:51:14]

Patchset #11 (id:390001) has been deleted

[stefan-webrtc, 2016-05-06 10:56:14]

Can this CL be closed, or should we make an effort getting it in?

[åsapersson, 2016-05-23 09:41:34]

asapersson@webrtc.org changed reviewers:
- hta@webrtc.org, mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org