Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1264693003: Add QP stats for sent video streams to StatsReport.

Created:
3 years, 10 months ago by åsapersson
Modified:
2 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, perkj_webrtc, andresp, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add QP stats for sent video streams to StatsReport for tracking video quality. A running average of the QP (per-frame value) for a sent VP8 video stream is reported (all TL layers included). The QP for the highest resolution stream is reported. QP range is 0-127. Add histogram stats for average QP per frame for VP8 (for sent video streams): - "WebRTC.Video.Encoded.VP8.Qp" BUG=webrtc:3136

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : added comment #

Total comments: 2

Patch Set 4 : modified comment #

Patch Set 5 : update metric name #

Patch Set 6 : rebase #

Patch Set 7 : #

Patch Set 8 : rebase #

Patch Set 9 : add qp to StatsReport #

Patch Set 10 : #

Patch Set 11 : add unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M talk/app/webrtc/statscollector.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/statstypes.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M talk/app/webrtc/statstypes.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -0 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +45 lines, -0 lines 0 comments Download
M webrtc/video_send_stream.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 39 (27 generated)
åsapersson
3 years, 10 months ago (2015-08-12 06:10:54 UTC) #3
stefan-webrtc
lgtm https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statistics_proxy.h#newcode135 webrtc/video/send_statistics_proxy.h:135: std::map<uint32_t, QpCounters> qp_counters_ GUARDED_BY(crit_); Comment on what the ...
3 years, 9 months ago (2015-09-03 12:01:22 UTC) #6
åsapersson
https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1264693003/diff/40001/webrtc/video/send_statistics_proxy.h#newcode135 webrtc/video/send_statistics_proxy.h:135: std::map<uint32_t, QpCounters> qp_counters_ GUARDED_BY(crit_); On 2015/09/03 12:01:21, stefan-webrtc (holmer) ...
3 years, 9 months ago (2015-09-03 14:40:48 UTC) #7
pbos-webrtc
lgtm https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statistics_proxy.h#newcode135 webrtc/video/send_statistics_proxy.h:135: // QP counters mapped by the SSRC. s/the ...
3 years, 9 months ago (2015-09-03 14:50:21 UTC) #8
åsapersson
https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statistics_proxy.h File webrtc/video/send_statistics_proxy.h (right): https://codereview.webrtc.org/1264693003/diff/60001/webrtc/video/send_statistics_proxy.h#newcode135 webrtc/video/send_statistics_proxy.h:135: // QP counters mapped by the SSRC. On 2015/09/03 ...
3 years, 9 months ago (2015-09-03 15:13:24 UTC) #9
stefan-webrtc
lgtm
3 years, 9 months ago (2015-09-03 15:32:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264693003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264693003/80001
3 years, 9 months ago (2015-09-04 06:28:45 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/598)
3 years, 9 months ago (2015-09-04 06:30:17 UTC) #15
mflodman
On 2015/09/04 06:30:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2015-09-08 11:42:38 UTC) #16
åsapersson
On 2015/09/08 11:42:38, mflodman wrote: > On 2015/09/04 06:30:17, commit-bot: I haz the power wrote: ...
3 years, 9 months ago (2015-09-08 12:27:40 UTC) #17
åsapersson
I have updated the CL to also add the QP to StatsReport, ptal. Adding hta ...
3 years, 6 months ago (2015-11-25 12:41:44 UTC) #31
stefan-webrtc
3 years, 1 month ago (2016-05-06 10:56:14 UTC) #38
Can this CL be closed, or should we make an effort getting it in?

Powered by Google App Engine
This is Rietveld 408576698