Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1253573005: Revert of Allow more than 2 input channels in AudioProcessing. (Closed)

Created:
5 years, 5 months ago by magjed_webrtc
Modified:
5 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, aluebs-webrtc, bjornv1, ekm
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Allow more than 2 input channels in AudioProcessing. (patchset #13 id:240001 of https://codereview.webrtc.org/1226093007/) Reason for revert: Breaks Chromium FYI content_browsertest on all platforms. The testcase that fails is WebRtcAecDumpBrowserTest.CallWithAecDump. https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux/builds/19388 Sample output: [ RUN ] WebRtcAecDumpBrowserTest.CallWithAecDump Xlib: extension "RANDR" missing on display ":9". [4:14:0722/211548:1282124453:WARNING:webrtcvoiceengine.cc(472)] Unexpected codec: ISAC/48000/1 (105) [4:14:0722/211548:1282124593:WARNING:webrtcvoiceengine.cc(472)] Unexpected codec: PCMU/8000/2 (110) [4:14:0722/211548:1282124700:WARNING:webrtcvoiceengine.cc(472)] Unexpected codec: PCMA/8000/2 (118) [4:14:0722/211548:1282124815:WARNING:webrtcvoiceengine.cc(472)] Unexpected codec: G722/8000/2 (119) [19745:19745:0722/211548:1282133667:INFO:CONSOLE(64)] "Looking at video in element remote-view-1", source: http://127.0.0.1:48819/media/webrtc_test_utilities.js (64) [19745:19745:0722/211548:1282136892:INFO:CONSOLE(64)] "Looking at video in element remote-view-2", source: http://127.0.0.1:48819/media/webrtc_test_utilities.js (64) ../../content/test/webrtc_content_browsertest_base.cc:62: Failure Value of: ExecuteScriptAndExtractString( shell()->web_contents(), javascript, &result) Actual: false Expected: true Failed to execute javascript call({video: true, audio: true});. From javascript: (nothing) When executing 'call({video: true, audio: true});' ../../content/test/webrtc_content_browsertest_base.cc:75: Failure Failed ../../content/browser/media/webrtc_aecdump_browsertest.cc:26: Failure Expected: (base::kNullProcessId) != (*id), actual: 0 vs 0 ../../content/browser/media/webrtc_aecdump_browsertest.cc:95: Failure Value of: GetRenderProcessHostId(&render_process_id) Actual: false Expected: true ../../content/browser/media/webrtc_aecdump_browsertest.cc:99: Failure Value of: base::PathExists(dump_file) Actual: false Expected: true ../../content/browser/media/webrtc_aecdump_browsertest.cc:101: Failure Value of: base::GetFileSize(dump_file, &file_size) Actual: false Expected: true ../../content/browser/media/webrtc_aecdump_browsertest.cc:102: Failure Expected: (file_size) > (0), actual: 0 vs 0 [ FAILED ] WebRtcAecDumpBrowserTest.CallWithAecDump, where TypeParam = and GetParam() = (361 ms) Original issue's description: > Allow more than 2 input channels in AudioProcessing. > > The number of output channels is constrained to be equal to either 1 or the > number of input channels. > > R=aluebs@webrtc.org, andrew@webrtc.org, pbos@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/c204754b7a0cc801c70e8ce6c689f57f6ce00b3b TBR=andrew@webrtc.org,aluebs@webrtc.org,ajm@chromium.org,pbos@chromium.org,pbos@webrtc.org,mgraczyk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/64e753c3998a17429418180b3a947231a9fd98cd Cr-Commit-Position: refs/heads/master@{#9621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -715 lines) Patch
M talk/media/webrtc/fakewebrtcvoiceengine.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/common_audio/audio_util.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/common_audio/audio_util_unittest.cc View 6 chunks +17 lines, -131 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 6 chunks +12 lines, -67 lines 0 comments Download
M webrtc/common_audio/wav_file.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.h View 1 chunk +6 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_buffer.cc View 7 chunks +62 lines, -30 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 6 chunks +55 lines, -18 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 30 chunks +183 lines, -218 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 8 chunks +7 lines, -135 lines 0 comments Download
M webrtc/modules/audio_processing/include/mock_audio_processing.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_processing_unittest.cc View 4 chunks +23 lines, -77 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
magjed_webrtc
Created Revert of Allow more than 2 input channels in AudioProcessing.
5 years, 5 months ago (2015-07-23 11:29:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253573005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253573005/1
5 years, 5 months ago (2015-07-23 11:30:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 11:30:11 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 11:30:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64e753c3998a17429418180b3a947231a9fd98cd
Cr-Commit-Position: refs/heads/master@{#9621}

Powered by Google App Engine
This is Rietveld 408576698