BWE Simulation Framework: Standard plot logging

webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh

Index: webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh
diff --git a/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh b/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh
old mode 100644
new mode 100755
index cb31825cd9ee63ce83e093c009b4ebd8c5a28484..e97f56cb4e6a93ca39e22c006bc8009455c4e08e
--- a/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh
+++ b/webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh
@@ -34,11 +34,14 @@ function gen_gnuplot_input {
   for figure in "${figures[@]}" ; do
     data_sets=$(echo "$plots" | grep "^PLOT.$figure" | cut -f 3 | sort | uniq)
     linetypes=($(echo "$data_sets" | grep "#" | cut -d '#' -f 2 | \
-      cut -d ' ' -f 1))
+      cut -d ' ' -f 1  | cut -d '@' -f 1))
+    delay_line=$(echo "$linetypes" | grep "d")
+
     echo "reset; "
     echo "set terminal wxt $figure size 1440,900 font \"Arial,9\"; "
     echo "set xlabel \"Seconds\"; "
-    if (( "${#linetypes[@]}" > "0" )); then
+
+    if (( "${#delay_line}" > "0" )); then

[stefan-webrtc, 2015/07/24 09:30:43]

Previously, this checked if we had more than a single y-axis, that is, if
linetypes contained only "1", that meant a single axis, while if it contained
both "1" and "2" (or was it 0 and 1?) we had two axis, which we assumed to be
bitrate and delay. How has this been changed now?

[magalhaesc, 2015/07/24 13:51:40]

Adopting back the convention:
1 - left side axis
2 - right side axis

       echo "set ylabel 'bitrate (kbps)';"
       echo "set ytics nomirror;"
       echo "set y2label 'time delta (ms)';"
@@ -53,11 +56,14 @@ function gen_gnuplot_input {
       echo -n "ps 0.5 "
       echo -n "lc rgbcolor \"#${colors[$(($i % 10))]}\" "
       if (( "${#linetypes[@]}" > "0" )); then
-        if (( "$i" <= "${#linetypes[@]}" )); then
-          echo -n "axes x1y${linetypes[$i - 1]} "
+        delay_line=($(echo "$set" | grep "#" | cut -d '#' -f 2 | \
+                    cut -d ' ' -f 1  | cut -d '@' -f 1 | grep "d"))
+        if (( "${#delay_line}" > "0" )); then
+          # 'd' stands for delay, plot scaled on the right side.
+          echo -n "axes x1y2 "

[stefan-webrtc, 2015/07/24 09:30:43]

Previously, this checked if we had more than a single y-axis, that is, if
linetypes contained only "1", that meant a single axis, while if it contained
both "1" and "2" (or was it 0 and 1?) we had two axis, which we assumed to be
bitrate and delay.

Are you now proposing to have #d for delay? Should we in that case have #b for
bitrate?

[magalhaesc, 2015/07/24 13:51:40]

Adopting back the convention:
1 - left side axis
2 - right side axis

         else
           # If no line type is specified, but line types are used, we will
-          # default to the bitrate axis.
+          # default to scale on the left side.
           echo -n "axes x1y1 "
         fi
       fi