BWE Simulation Framework: Standard plot logging

webrtc/modules/remote_bitrate_estimator/test/plot_dynamics.sh

 #!/bin/bash
 
 # Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
@@ skipping 16 matching lines @@
 
 # Plot dynamics.
 function gen_gnuplot_input {
   colors=(a7001f 0a60c2 b2582b 21a66c d6604d 4393c3 f4a582 92c5de edcbb7 b1c5d0)
   plots=$(echo "$log" | grep "^PLOT")
   figures=($(echo "$plots" | cut -f 2 | sort | uniq))
 
   for figure in "${figures[@]}" ; do
     data_sets=$(echo "$plots" | grep "^PLOT.$figure" | cut -f 3 | sort | uniq)
     linetypes=($(echo "$data_sets" | grep "#" | cut -d '#' -f 2 | \
-      cut -d ' ' -f 1))
+      cut -d ' ' -f 1  | cut -d '@' -f 1))
+    delay_line=$(echo "$linetypes" | grep "d")
+
     echo "reset; "
     echo "set terminal wxt $figure size 1440,900 font \"Arial,9\"; "
     echo "set xlabel \"Seconds\"; "
-    if (( "${#linetypes[@]}" > "0" )); then
+
+    if (( "${#delay_line}" > "0" )); then

[stefan-webrtc, 2015/07/24 09:30:43]

Previously, this checked if we had more than a single y-axis, that is, if
linetypes contained only "1", that meant a single axis, while if it contained
both "1" and "2" (or was it 0 and 1?) we had two axis, which we assumed to be
bitrate and delay. How has this been changed now?

[magalhaesc, 2015/07/24 13:51:40]

Adopting back the convention:
1 - left side axis
2 - right side axis

       echo "set ylabel 'bitrate (kbps)';"
       echo "set ytics nomirror;"
       echo "set y2label 'time delta (ms)';"
       echo "set y2tics nomirror;"
     fi
     echo -n "plot "
     i=0
     for set in $data_sets ; do
       (( i++ )) && echo -n ","
       echo -n "'-' with "
       echo -n "linespoints "
       echo -n "ps 0.5 "
       echo -n "lc rgbcolor \"#${colors[$(($i % 10))]}\" "
       if (( "${#linetypes[@]}" > "0" )); then
-        if (( "$i" <= "${#linetypes[@]}" )); then
-          echo -n "axes x1y${linetypes[$i - 1]} "
+        delay_line=($(echo "$set" | grep "#" | cut -d '#' -f 2 | \
+                    cut -d ' ' -f 1  | cut -d '@' -f 1 | grep "d"))
+        if (( "${#delay_line}" > "0" )); then
+          # 'd' stands for delay, plot scaled on the right side.
+          echo -n "axes x1y2 "

[stefan-webrtc, 2015/07/24 09:30:43]

Previously, this checked if we had more than a single y-axis, that is, if
linetypes contained only "1", that meant a single axis, while if it contained
both "1" and "2" (or was it 0 and 1?) we had two axis, which we assumed to be
bitrate and delay.

Are you now proposing to have #d for delay? Should we in that case have #b for
bitrate?

[magalhaesc, 2015/07/24 13:51:40]

Adopting back the convention:
1 - left side axis
2 - right side axis

         else
           # If no line type is specified, but line types are used, we will
-          # default to the bitrate axis.
+          # default to scale on the left side.
           echo -n "axes x1y1 "
         fi
       fi
       echo -n "title \"$set\" "
     done
     echo
     for set in $data_sets ; do
       echo "$log" | grep "^PLOT.$figure.$set" | cut -f 4,5
       echo "e"
     done
   done
 }
 gen_gnuplot_input | gnuplot -persist